feat: add --resource-check CLI flag to skip resource validation#2928
Open
mattevans wants to merge 1 commit intokurtosis-tech:mainfrom
Open
feat: add --resource-check CLI flag to skip resource validation#2928mattevans wants to merge 1 commit intokurtosis-tech:mainfrom
mattevans wants to merge 1 commit intokurtosis-tech:mainfrom
Conversation
mattevans
force-pushed
the
feat/resource-check-flag
branch
from
ededf01 to
49891cb
Compare
…validation The GetAvailableCPUAndMemory Docker API call during the validation phase takes multiple seconds. This adds a new --resource-check flag (default true) that lets users disable it with --resource-check=false when they know resources are sufficient.
mattevans
force-pushed
the
feat/resource-check-flag
branch
from
49891cb to
a1bef08
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
--resource-checkCLI flag (defaulttrue) that controls whetherGetAvailableCPUAndMemoryis called during the validation phase.--resource-check=falseto skip the Docker API call which takes multiple seconds.Is this change user facing?
YES