fix: parallel execution dependency graph for exec, start_service, stop_service#2930
Open
mattevans wants to merge 1 commit intokurtosis-tech:mainfrom
Open
fix: parallel execution dependency graph for exec, start_service, stop_service#2930mattevans wants to merge 1 commit intokurtosis-tech:mainfrom
mattevans wants to merge 1 commit intokurtosis-tech:mainfrom
Conversation
…el execution exec, start_service, and stop_service instructions mutate service state but weren't calling ProducesService() in the dependency graph. This meant store_service_files on the same service could race with a preceding exec, causing failures. Now exec, start_service, and stop_service all produce their service in the dependency graph, ensuring proper ordering with consumers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
exec,start_service, andstop_servicenow callProducesService()in the dependency graphstore_service_fileson the same service could race with a precedingexecin--parallelmodeError:
ethereum-packageconfig for reproducing:Is this change user facing?
YES - fixes race conditions when using
--parallel