fix(tests): guard against nil RunScript result in integration tests#2934
Open
barnabasbusa wants to merge 1 commit intomainfrom
Open
fix(tests): guard against nil RunScript result in integration tests#2934barnabasbusa wants to merge 1 commit intomainfrom
barnabasbusa wants to merge 1 commit intomainfrom
Conversation
When RunScript returns (nil, error) due to gRPC failures, tests that ignore the error and immediately access runResult fields panic with a nil pointer dereference. Add require.NotNil guards at 12 call sites across 10 test files to produce clean test failures instead of panics. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RunScript/RunRemotePackagereturns(nil, error)due to gRPC failures (context cancelled, engine unreachable), tests that ignore the error withrunResult, _ := ...and immediately accessrunResult.InterpretationErrorpanic with a nil pointer dereferencerequire.NotNil(t, runResult, "RunScript returned nil result")guards at 12 call sites across 10 test files to produce clean test failures instead of panicsstartosis_add_service_invalid_name_test.goandstartosis_remote_package_relative_import_test.go) already had the guard and were left unchangedTest plan
go vet ./...passes ininternal_testsuites/golang/go build ./...passes ininternal_testsuites/golang/🤖 Generated with Claude Code