Generic implementation of Max and Min functions.

[mobilebilly]

Summary

Supports number, string, and boolean types using built-in comparers.
For unsupported types, a custom comparer must be provided.

Details

This pull request is important and essential because it addresses a fundamental limitation in the existing implementation by removing the hardcoded assumption that all comparers return a number. By introducing support for built-in comparers for number, string, and boolean types—and requiring explicit custom comparers for other types—we significantly improve type safety, flexibility, and clarity in the API.

Additionally, the updated method signatures now better reflect the semantics of similar functionality in C#, aligning the design with established .NET practices. This not only enhances code readability and maintainability for developers familiar with LINQ-style patterns, but also lays a stronger foundation for future extensibility.

Breaking change:

The method signatures have been modified to avoid hardcoding the return type as number. The new design more closely aligns with the original implementation in C# and improves type flexibility.

From:

Max(selector?: (element: T, index: number) => number): number
Min(selector?: (element: T, index: number) => number): number

To:

Max(comparer?: (element: T) => number): T | undefined
Min(comparer?: (element: T) => number): T | undefined

[coveralls]

coverage: 100.0%. remained the same
when pulling 56de1e7 on mobilebilly:feature/generic-max-min
into dbc501b on kutyel:master.

[kutyel]

Hi!

Thank you very much for you contribution, it looks really good and I'm happy to merge it as a major change if you address a couple of minor comments I have 😉

When merging this with a major commit message a new mayor release will be auto-released so no worry about the breaking changes.

Thanks for your effort and work you put into this! I especially appreciate the effort you made to make it closer to C#, this was the overall goal of this library after all! 👏🏻

[kutyel]

LGTM, huge thanks for you contribution! 🎉

[github-actions]

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀