Skip to content
This repository was archived by the owner on Oct 10, 2025. It is now read-only.

Fix extension-only build #4876

Merged
royi-luo merged 1 commit intomasterfrom
royi/fix-extension-includes
Feb 10, 2025
Merged

Fix extension-only build #4876
royi-luo merged 1 commit intomasterfrom
royi/fix-extension-includes

Conversation

@royi-luo
Copy link
Contributor

@royi-luo royi-luo commented Feb 10, 2025

Description

Explicitlty add directory including generated headers (in ${CMAKE_BINARY_DIR}/src/include) to include directories when building extensions.

The extension compile seems to be working now

Contributor agreement

@royi-luo royi-luo requested a review from ray6080 February 10, 2025 14:54
@royi-luo royi-luo self-assigned this Feb 10, 2025
@github-actions
Copy link

Benchmark Result

Master commit hash: 3b37b0845e07fa51e47f9dfecf4f2f87ee399e42
Branch commit hash: bbbfc57d4b9f0ad5ec6b65e6b9199199823f321e

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 717.69 731.20 -13.51 (-1.85%)
aggregation q28 6335.16 6339.96 -4.80 (-0.08%)
filter q14 117.33 118.57 -1.23 (-1.04%)
filter q15 120.28 115.52 4.76 (4.12%)
filter q16 304.81 309.00 -4.19 (-1.36%)
filter q17 445.59 444.76 0.83 (0.19%)
filter q18 1935.98 1911.24 24.74 (1.29%)
filter zonemap-node 80.37 83.03 -2.66 (-3.20%)
filter zonemap-node-lhs-cast 82.59 81.52 1.07 (1.32%)
filter zonemap-node-null 81.63 80.69 0.93 (1.16%)
filter zonemap-rel 5438.46 5471.28 -32.81 (-0.60%)
fixed_size_expr_evaluator q07 562.40 563.42 -1.02 (-0.18%)
fixed_size_expr_evaluator q08 791.36 795.32 -3.96 (-0.50%)
fixed_size_expr_evaluator q09 798.67 796.53 2.14 (0.27%)
fixed_size_expr_evaluator q10 228.34 228.96 -0.62 (-0.27%)
fixed_size_expr_evaluator q11 221.64 222.04 -0.40 (-0.18%)
fixed_size_expr_evaluator q12 221.38 217.14 4.24 (1.95%)
fixed_size_expr_evaluator q13 1446.15 1447.51 -1.36 (-0.09%)
fixed_size_seq_scan q23 103.24 105.86 -2.62 (-2.48%)
join q29 743.81 715.70 28.12 (3.93%)
join q30 10735.13 9894.64 840.49 (8.49%)
join q31 7.42 7.14 0.28 (3.96%)
join SelectiveTwoHopJoin 50.25 55.23 -4.99 (-9.03%)
ldbc_snb_ic q35 2544.00 2689.46 -145.46 (-5.41%)
ldbc_snb_ic q36 490.59 474.01 16.57 (3.50%)
ldbc_snb_is q32 6.99 5.73 1.26 (22.07%)
ldbc_snb_is q33 15.54 15.37 0.18 (1.15%)
ldbc_snb_is q34 1.28 1.18 0.10 (8.51%)
multi-rel multi-rel-large-scan 1415.72 1397.44 18.28 (1.31%)
multi-rel multi-rel-lookup 23.93 31.59 -7.66 (-24.24%)
multi-rel multi-rel-small-scan 59.27 55.71 3.55 (6.38%)
order_by q25 121.69 123.06 -1.37 (-1.12%)
order_by q26 441.94 440.62 1.31 (0.30%)
order_by q27 1433.98 1437.25 -3.27 (-0.23%)
recursive_join recursive-join-bidirection 319.05 315.22 3.83 (1.21%)
recursive_join recursive-join-dense 7393.30 7359.64 33.65 (0.46%)
recursive_join recursive-join-path 24249.46 24295.00 -45.55 (-0.19%)
recursive_join recursive-join-sparse 1057.47 1047.62 9.86 (0.94%)
recursive_join recursive-join-trail 7303.39 7333.16 -29.77 (-0.41%)
scan_after_filter q01 167.16 168.37 -1.21 (-0.72%)
scan_after_filter q02 148.83 151.14 -2.31 (-1.53%)
shortest_path_ldbc100 q37 89.99 100.48 -10.48 (-10.43%)
shortest_path_ldbc100 q38 287.26 387.24 -99.98 (-25.82%)
shortest_path_ldbc100 q39 67.83 64.98 2.85 (4.38%)
shortest_path_ldbc100 q40 448.68 462.65 -13.96 (-3.02%)
var_size_expr_evaluator q03 2061.36 2093.01 -31.65 (-1.51%)
var_size_expr_evaluator q04 2239.90 2232.23 7.67 (0.34%)
var_size_expr_evaluator q05 2683.01 2663.57 19.45 (0.73%)
var_size_expr_evaluator q06 1324.43 1321.14 3.29 (0.25%)
var_size_seq_scan q19 1438.00 1443.32 -5.32 (-0.37%)
var_size_seq_scan q20 2327.35 2341.89 -14.54 (-0.62%)
var_size_seq_scan q21 2291.60 2302.94 -11.34 (-0.49%)
var_size_seq_scan q22 123.97 126.92 -2.94 (-2.32%)

@codecov
Copy link

codecov bot commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (master@3b37b08). Learn more about missing BASE report.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #4876   +/-   ##
=========================================
  Coverage          ?   86.53%           
=========================================
  Files             ?     1403           
  Lines             ?    60536           
  Branches          ?     7441           
=========================================
  Hits              ?    52384           
  Misses            ?     7983           
  Partials          ?      169           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@royi-luo royi-luo merged commit b3f88d7 into master Feb 10, 2025
30 checks passed
@royi-luo royi-luo deleted the royi/fix-extension-includes branch February 10, 2025 17:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants