Skip to content
This repository was archived by the owner on Oct 10, 2025. It is now read-only.

Fix macOS ARM64 extension release#5651

Merged
mewim merged 1 commit intomasterfrom
mac-extension-release-fix
Jul 4, 2025
Merged

Fix macOS ARM64 extension release#5651
mewim merged 1 commit intomasterfrom
mac-extension-release-fix

Conversation

@mewim
Copy link
Contributor

@mewim mewim commented Jul 4, 2025

Now the OpenSSL version has been upgraded to 3.5.0. The outdated OPENSSL_ROOT_DIR causes CMake not able to resolve the path for OpenSSL. I figured that without it CMake can resolve OpenSSL automnatically, so it should be removed.

Vefified by https://github.com/kuzudb/kuzu/actions/runs/16077503113

@mewim mewim requested a review from Copilot July 4, 2025 16:08
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the hardcoded OPENSSL_ROOT_DIR override so CMake can automatically locate the newly upgraded OpenSSL 3.5.0 on macOS ARM64.

  • Dropped the env OPENSSL_ROOT_DIR=… prefix from the build step
  • Simplified the make extension-release invocation
Comments suppressed due to low confidence (1)

.github/workflows/build-extensions.yml:57

  • [nitpick] Consider adding a comment above this step explaining why the explicit OPENSSL_ROOT_DIR override was removed, so future maintainers understand that CMake now auto-discovers OpenSSL 3.5.0.
        run: make extension-release NUM_THREADS=$(sysctl -n hw.logicalcpu)

@mewim mewim merged commit ba4228c into master Jul 4, 2025
10 of 28 checks passed
@mewim mewim deleted the mac-extension-release-fix branch July 4, 2025 16:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants