This repository was archived by the owner on Oct 10, 2025. It is now read-only.
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6052 +/- ##
=======================================
Coverage 86.26% 86.26%
=======================================
Files 1463 1463
Lines 67129 67127 -2
Branches 8180 8182 +2
=======================================
- Hits 57911 57910 -1
+ Misses 8952 8951 -1
Partials 266 266
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Benchmark ResultMaster commit hash:
Other queries
|
royi-luo
approved these changes
Oct 8, 2025
| -STATEMENT CREATE (n8: tab {uint128key: NULL, value: 1}) return n8.*; | ||
| ---- error | ||
| Runtime exception: Found NULL, which violates the non-null constraint of the primary key column. | ||
|
|
Contributor
There was a problem hiding this comment.
Can you add some more statements to check that matching by primary key works?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add hash index for the UINT128 type and support using it as a primary key.
Contributor agreement