Skip to content

fix(transfer_engine): Add notify callback registration in RPC metadata handling #966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(transfer_engine): Add notify callback registration in RPC metadata handling #966

wants to merge 2 commits into from
+9 −4

Conversation

@iBenzene
Copy link

If the registration for the Notify callback function is not added in the addRpcMetaEntry function, the P2PHANDSHAKE method will not work. An example is the testing program for the NIXL backend Mooncake integration plugin.

I1025 16:48:45.144167 87366 transfer_metadata_plugin.cpp:752] SocketHandShakePlugin: received handshake message of type 2, json string length: 38, json string content: {"name":"Agent1","notify_msg":"test"}
I1025 16:48:45.144309 87366 transfer_metadata_plugin.cpp:778] SocketHandShakePlugin: [RECEIVER] Before callback, local is empty
I1025 16:48:45.144345 87366 transfer_metadata_plugin.cpp:780] SocketHandShakePlugin: [RECEIVER] After callback, local content: null
I1025 16:48:45.144373 87366 transfer_metadata_plugin.cpp:790] SocketHandShakePlugin: [RECEIVER] Sending reply, type=2, json length=5, content: null
I1025 16:48:45.144551 87363 transfer_metadata_plugin.cpp:1035] SocketHandShakePlugin: [SENDER] Received reply, type=2, json length=5, content: null
I1025 16:48:45.144593 87363 transfer_metadata_plugin.cpp:1047] SocketHandShakePlugin: received notify message: null
E1025 16:48:45.144726 87363 transfer_metadata.cpp:745] Notify rejected by 192.168.0.27:16430:

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @iBenzene, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical bug in the transfer engine where the P2P handshake process was failing because a necessary Notify callback was not being registered. By adding the registration for this callback within the RPC metadata handling logic, the change ensures that the P2P handshake can complete successfully, thereby enabling proper peer-to-peer communication and resolving a key functional impediment.

Highlights

  • P2P Handshake Fix: Resolved an issue where the P2P handshake mechanism would fail due to the Notify callback not being registered, preventing proper communication.
  • Callback Registration: Ensured that the registerOnNotifyCallBack function is called within the addRpcMetaEntry method when p2p_handshake_mode_ is active, allowing the receivePeerNotify function to be properly handled.
  • Daemon Start Order: Reordered the startDaemon call to occur after both OnMetadataCallBack and OnNotifyCallBack registrations, ensuring all necessary callbacks are set up before the daemon begins.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Oct 25, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes an issue where the P2PHANDSHAKE method would fail by adding the missing registration for the Notify callback. The change also correctly moves the startDaemon call to after all callbacks are registered, which is a good practice to prevent race conditions. I've added one suggestion to improve robustness by checking for a null handshake_plugin_ before use, preventing a potential crash.

alogfans
alogfans approved these changes Oct 27, 2025
View reviewed changes
Copy link
Collaborator

@alogfans alogfans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@stmatengss stmatengss requested a review from doujiang24 October 27, 2025 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alogfans alogfans alogfans approved these changes

@doujiang24 doujiang24 Awaiting requested review from doujiang24

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@iBenzene @alogfans