Skip to content

fix(transfer_engine): Add notify callback registration in RPC metadata handling #966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+9 −4
Open

fix(transfer_engine): Add notify callback registration in RPC metadata handling #966

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3319582
fix(transfer_engine): Add notify callback registration in RPC metadat…
iBenzene Oct 25, 2025
2a8bcdf
chore(transfer_metadata): Remove unnecessary spaces or tabs
iBenzene Oct 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions mooncake-transfer-engine/src/transfer_metadata.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -608,14 +608,19 @@ int TransferMetadata::addRpcMetaEntry(const std::string &server_name,
local_rpc_meta_ = desc;

if (p2p_handshake_mode_) {
int rc = handshake_plugin_->startDaemon(desc.rpc_port, desc.sockfd);
if (rc != 0) {
return rc;
}
handshake_plugin_->registerOnMetadataCallBack(
[this](const Json::Value &peer, Json::Value &local) -> int {
return receivePeerMetadata(peer, local);
});
handshake_plugin_->registerOnNotifyCallBack(
[this](const Json::Value &peer, Json::Value &local) -> int {
return receivePeerNotify(peer, local);
});

int rc = handshake_plugin_->startDaemon(desc.rpc_port, desc.sockfd);
if (rc != 0) {
return rc;
}

return 0;
}
Expand Down