Skip to content

update ci test#1647

Merged
ovowei merged 13 commits intomainfrom
add-ci-djw
Nov 27, 2025
Merged

update ci test#1647
ovowei merged 13 commits intomainfrom
add-ci-djw

Conversation

@ovowei
Copy link
Collaborator

@ovowei ovowei commented Nov 27, 2025

No description provided.

@ovowei ovowei added the run-ci label Nov 27, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @ovowei, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the efficiency and reliability of the continuous integration (CI) test suite. It achieves this by optimizing resource allocation for specific benchmark tests and implementing robust handling of test runner exit codes, which is crucial for accurate pass/fail reporting in automated CI pipelines.

Highlights

  • Resource Optimization for Benchmark Tests: The subpool_thread_count and CPUINFER_PARAM values have been reduced in the test_moe_amx_bench_int4.py and test_moe_amx_bench_int8.py files, likely to decrease resource consumption and execution time for these CI benchmarks.
  • Improved CI Exit Code Handling: The run_suite.py script now correctly propagates the exit status of the run_unittest_files function to the system's exit code, ensuring that CI systems accurately reflect the success or failure of test runs.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to update the CI tests. It correctly modifies run_suite.py to propagate test failure exit codes, which is a good improvement for CI integration. I've suggested a small simplification to make the exit code handling more concise and robust. However, a critical issue is that two test files, test_moe_amx_bench_int4.py and test_moe_amx_bench_int8.py, contain unresolved merge conflict markers. These will cause syntax errors and must be resolved before this PR can be merged.

Comment on lines +48 to +56
<<<<<<< HEAD
"subpool_thread_count": [30, 30],
}
CPUINFER_PARAM = 60
=======
"subpool_thread_count": [45, 45],
}
CPUINFER_PARAM = 90
>>>>>>> main
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This file contains unresolved merge conflict markers (<<<<<<<, =======, >>>>>>>). These markers will cause a syntax error and must be removed. Please resolve the conflict and commit the correct version of the code.

    "subpool_thread_count": [30, 30],
}
CPUINFER_PARAM = 60

Comment on lines +48 to +56
<<<<<<< HEAD
"subpool_thread_count": [30, 30],
}
CPUINFER_PARAM = 60
=======
"subpool_thread_count": [45, 45],
}
CPUINFER_PARAM = 90
>>>>>>> main
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This file contains unresolved merge conflict markers (<<<<<<<, =======, >>>>>>>). These markers will cause a syntax error and must be removed. Please resolve the conflict and commit the correct version of the code.

    "subpool_thread_count": [30, 30],
}
CPUINFER_PARAM = 60

Comment on lines +65 to +68
exit_code = run_per_commit(hw, args.suite)
# run_unittest_files returns 0 for success, -1 for failure
# Convert to standard exit codes: 0 for success, 1 for failure
sys.exit(0 if exit_code == 0 else 1)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The logic to convert the internal exit code to a standard shell exit code is correct. However, it can be simplified to be more robust and concise. The expression exit_code != 0 evaluates to False (which sys.exit treats as 0) for success and True (treated as 1) for any failure, which is more robust if the failure code ever changes from -1.

Suggested change
exit_code = run_per_commit(hw, args.suite)
# run_unittest_files returns 0 for success, -1 for failure
# Convert to standard exit codes: 0 for success, 1 for failure
sys.exit(0 if exit_code == 0 else 1)
exit_code = run_per_commit(hw, args.suite)
# run_unittest_files returns 0 for success, non-zero for failure.
# Convert to standard exit codes: 0 for success, 1 for failure.
sys.exit(exit_code != 0)

@ovowei ovowei merged commit c256150 into main Nov 27, 2025
7 of 9 checks passed
KMSorSMS pushed a commit that referenced this pull request Dec 11, 2025
@KMSorSMS KMSorSMS deleted the add-ci-djw branch December 11, 2025 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant