Conversation
Summary of ChangesHello @ovowei, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing the efficiency and reliability of the continuous integration (CI) test suite. It achieves this by optimizing resource allocation for specific benchmark tests and implementing robust handling of test runner exit codes, which is crucial for accurate pass/fail reporting in automated CI pipelines. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request aims to update the CI tests. It correctly modifies run_suite.py to propagate test failure exit codes, which is a good improvement for CI integration. I've suggested a small simplification to make the exit code handling more concise and robust. However, a critical issue is that two test files, test_moe_amx_bench_int4.py and test_moe_amx_bench_int8.py, contain unresolved merge conflict markers. These will cause syntax errors and must be resolved before this PR can be merged.
| <<<<<<< HEAD | ||
| "subpool_thread_count": [30, 30], | ||
| } | ||
| CPUINFER_PARAM = 60 | ||
| ======= | ||
| "subpool_thread_count": [45, 45], | ||
| } | ||
| CPUINFER_PARAM = 90 | ||
| >>>>>>> main |
There was a problem hiding this comment.
| <<<<<<< HEAD | ||
| "subpool_thread_count": [30, 30], | ||
| } | ||
| CPUINFER_PARAM = 60 | ||
| ======= | ||
| "subpool_thread_count": [45, 45], | ||
| } | ||
| CPUINFER_PARAM = 90 | ||
| >>>>>>> main |
There was a problem hiding this comment.
| exit_code = run_per_commit(hw, args.suite) | ||
| # run_unittest_files returns 0 for success, -1 for failure | ||
| # Convert to standard exit codes: 0 for success, 1 for failure | ||
| sys.exit(0 if exit_code == 0 else 1) |
There was a problem hiding this comment.
The logic to convert the internal exit code to a standard shell exit code is correct. However, it can be simplified to be more robust and concise. The expression exit_code != 0 evaluates to False (which sys.exit treats as 0) for success and True (treated as 1) for any failure, which is more robust if the failure code ever changes from -1.
| exit_code = run_per_commit(hw, args.suite) | |
| # run_unittest_files returns 0 for success, -1 for failure | |
| # Convert to standard exit codes: 0 for success, 1 for failure | |
| sys.exit(0 if exit_code == 0 else 1) | |
| exit_code = run_per_commit(hw, args.suite) | |
| # run_unittest_files returns 0 for success, non-zero for failure. | |
| # Convert to standard exit codes: 0 for success, 1 for failure. | |
| sys.exit(exit_code != 0) |
No description provided.