[chore](cuda): explicitly use ele_per_blk var for better readability#1784
Conversation
Summary of ChangesHello @SCDESPERTATE, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on improving the clarity and future scalability of the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request improves code readability and maintainability by replacing hardcoded numeric values with the ele_per_blk variable when creating output tensors. The changes are applied consistently across all dequant.* functions in both modified files. This is a good refactoring that makes the code cleaner and easier to understand.
On a related note, I observed that kt-kernel/cuda/custom_gguf/dequant.cu and kt-sft/csrc/ktransformers_ext/cuda/custom_gguf/dequant.cu appear to be identical. This code duplication is a significant maintainability concern. This pull request itself highlights the issue, as the same change had to be applied in two separate places. I strongly recommend consolidating these files into a single source in a future effort to reduce maintenance overhead and prevent potential inconsistencies.
What does this PR do?
The current implementation of the
dequant.*functions in the custom_gguf module uses hardcoded numeric values when creating the output tensor, which reduces readability and could hinder future scalability. This PR replaces these hardcoded values with the name of the variable holding it.Before submitting