Skip to content

[kt-kernel] Fix ignored build configurations in install.sh and CMakeLists.txt#1789

Merged
KMSorSMS merged 2 commits intokvcache-ai:mainfrom
watamario15:patch-1
Jan 12, 2026
Merged

[kt-kernel] Fix ignored build configurations in install.sh and CMakeLists.txt#1789
KMSorSMS merged 2 commits intokvcache-ai:mainfrom
watamario15:patch-1

Conversation

@watamario15
Copy link
Contributor

What does this PR do?

Fixes #1747

Some additional comments:

  • The default value for CPUINFER_BUILD_TYPE is defined at https://github.com/kvcache-ai/ktransformers/blob/main/kt-kernel/setup.py#L113, thus not needed in install.sh.
  • The rewrite from pip install . to python3 -m pip install . is to prevent uv setups without pip in the virtual environment from calling the system pip instead.
    • As it's better to call uv pip in uv environments, this is just a quick fix.

Before submitting

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @watamario15, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the build and installation process for the kt-kernel module by addressing issues where build configurations were being ignored or overridden. It enhances the flexibility of CMake build type settings and ensures that the install.sh script correctly respects environment variables for build parameters, while also improving the robustness of the Python package installation command.

Highlights

  • CMake Build Configuration: Removed hardcoded CMAKE_BUILD_TYPE settings in CMakeLists.txt to allow external build configurations to be respected, preventing previous overrides.
  • Installation Script Refinement: Streamlined install.sh by removing redundant default variable exports for CPUINFER_BUILD_TYPE, CPUINFER_PARALLEL, and CPUINFER_VERBOSE, which are now handled dynamically or are expected to be passed in.
  • Python Package Installation: Modified the pip install command in install.sh to explicitly use python3 -m pip install . and conditionally apply verbosity based on CPUINFER_VERBOSE, preventing potential issues with uv environments and ensuring correct pip usage.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly addresses an issue where build configurations were being ignored by removing the hardcoded CMAKE_BUILD_TYPE in CMakeLists.txt. The changes in install.sh are also solid improvements, such as removing redundant default variable settings, using python3 -m pip for better compatibility, and properly handling verbosity based on environment variables. The overall changes are logical and well-justified. I have one minor suggestion to improve the maintainability of the installation script.

Comment on lines +400 to +404
if [ ${CPUINFER_VERBOSE:-1} = "0" ]; then
python3 -m pip install .
else
python3 -m pip install . -v
fi
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve maintainability and avoid duplicating the python3 -m pip install . command, you could determine the verbosity flag first and then call the command once. This makes the script slightly cleaner and easier to modify in the future.

Suggested change
if [ ${CPUINFER_VERBOSE:-1} = "0" ]; then
python3 -m pip install .
else
python3 -m pip install . -v
fi
PIP_VERBOSE_FLAG=""
if [ "${CPUINFER_VERBOSE:-1}" != "0" ]; then
PIP_VERBOSE_FLAG="-v"
fi
python3 -m pip install . $PIP_VERBOSE_FLAG

@KMSorSMS KMSorSMS requested review from KMSorSMS and SkqLiao January 12, 2026 12:27
@KMSorSMS KMSorSMS merged commit 667030d into kvcache-ai:main Jan 12, 2026
9 checks passed
@KMSorSMS
Copy link
Collaborator

Thx for your help :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Install scripts always dismiss some build configurations.

2 participants