[kt-kernel] Fix ignored build configurations in install.sh and CMakeLists.txt#1789
[kt-kernel] Fix ignored build configurations in install.sh and CMakeLists.txt#1789KMSorSMS merged 2 commits intokvcache-ai:mainfrom
install.sh and CMakeLists.txt#1789Conversation
Summary of ChangesHello @watamario15, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the build and installation process for the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly addresses an issue where build configurations were being ignored by removing the hardcoded CMAKE_BUILD_TYPE in CMakeLists.txt. The changes in install.sh are also solid improvements, such as removing redundant default variable settings, using python3 -m pip for better compatibility, and properly handling verbosity based on environment variables. The overall changes are logical and well-justified. I have one minor suggestion to improve the maintainability of the installation script.
| if [ ${CPUINFER_VERBOSE:-1} = "0" ]; then | ||
| python3 -m pip install . | ||
| else | ||
| python3 -m pip install . -v | ||
| fi |
There was a problem hiding this comment.
To improve maintainability and avoid duplicating the python3 -m pip install . command, you could determine the verbosity flag first and then call the command once. This makes the script slightly cleaner and easier to modify in the future.
| if [ ${CPUINFER_VERBOSE:-1} = "0" ]; then | |
| python3 -m pip install . | |
| else | |
| python3 -m pip install . -v | |
| fi | |
| PIP_VERBOSE_FLAG="" | |
| if [ "${CPUINFER_VERBOSE:-1}" != "0" ]; then | |
| PIP_VERBOSE_FLAG="-v" | |
| fi | |
| python3 -m pip install . $PIP_VERBOSE_FLAG |
|
Thx for your help :) |
What does this PR do?
Fixes #1747
Some additional comments:
CPUINFER_BUILD_TYPEis defined at https://github.com/kvcache-ai/ktransformers/blob/main/kt-kernel/setup.py#L113, thus not needed ininstall.sh.pip install .topython3 -m pip install .is to preventuvsetups withoutpipin the virtual environment from calling the systempipinstead.uv pipinuvenvironments, this is just a quick fix.Before submitting