Skip to content

Conversation

@kylebarron
Copy link
Owner

  • fix current clippy errors

  • Implement pluggable distance calclations for spatial indexes

  • enable run rust and test for pr

  • fix cargo fmt

  • fix clippy issue

  • Apply suggestion from @copilot

Co-authored-by: Copilot [email protected]

  • Update src/type.rs

Co-authored-by: Copilot [email protected]

  • Update src/rtree/distance.rs

Co-authored-by: Copilot [email protected]

  • Update src/rtree/distance.rs

Co-authored-by: Copilot [email protected]

  • Update src/rtree/distance.rs

Co-authored-by: Copilot [email protected]

  • Removed the redundant distance check

  • fix compiling error


Co-authored-by: Copilot [email protected]

zhangfengcdt and others added 3 commits July 15, 2025 13:31
* fix current clippy errors

* Implement pluggable distance calclations for spatial indexes

* enable run rust and test for pr

* fix cargo fmt

* fix clippy issue

* Apply suggestion from @Copilot

Co-authored-by: Copilot <[email protected]>

* Update src/type.rs

Co-authored-by: Copilot <[email protected]>

* Update src/rtree/distance.rs

Co-authored-by: Copilot <[email protected]>

* Update src/rtree/distance.rs

Co-authored-by: Copilot <[email protected]>

* Update src/rtree/distance.rs

Co-authored-by: Copilot <[email protected]>

* Removed the redundant distance check

* fix compiling error

---------

Co-authored-by: Copilot <[email protected]>
@jiayuasu
Copy link

@kylebarron Hi Kyle, do you know what need to be done in order to merge this PR?

@kylebarron
Copy link
Owner Author

Primarily my time bandwidth to be able to adequately review this.

But also, I'm not excited about the prospect of vendoring dense spheroid math. I'd prefer depending on geo if we can use spheroid distances that have been implemented there

@zhangfengcdt
Copy link

Primarily my time bandwidth to be able to adequately review this.

But also, I'm not excited about the prospect of vendoring dense spheroid math. I'd prefer depending on geo if we can use spheroid distances that have been implemented there

Hi @kylebarron , thanks for the feedback on the PR. I've created a new pull request here: #141

This new version removes the vendored spheroid math and uses the geo crate for distance calculations as you suggested. I hope this addresses your concerns. I'd appreciate a review when you have a moment. Thanks!

CC: @Kontinuation @jiayuasu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants