Skip to content

fix: Add checking subtitleText in empty list component#4603

Merged
awoloszyn22 merged 8 commits intokyma-project:mainfrom
awoloszyn22:no-desc-in-empty-list
Feb 18, 2026
Merged

fix: Add checking subtitleText in empty list component#4603
awoloszyn22 merged 8 commits intokyma-project:mainfrom
awoloszyn22:no-desc-in-empty-list

Conversation

@awoloszyn22
Copy link
Contributor

@awoloszyn22 awoloszyn22 commented Feb 11, 2026

Description

Changes proposed in this pull request:

  • added checking if subtitleText isn't equal to resource.description in empty list component
  • added missing translation for command palette

Related issue(s)
Resolves #4558

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • revert: Revert commit
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

defaultSearch: true,
});

const { description: subtitleText, url: emptyListUrl } =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we have different function to create descriptions with links, so maybe this getResourceDescAndUrl can be reduced to only extract links?

@awoloszyn22 awoloszyn22 merged commit 2b67e7d into kyma-project:main Feb 18, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No description in Empty List Component in Destination Rules

3 participants