Skip to content

Conversation

@KacperMalachowski
Copy link

Description

In neighbors team, we need to validate only the possibility to push module template to registry.
It's required to write correct check for submission pipeline. See: https://github.tools.sap/kyma/test-infra/issues/469

Changes proposed in this pull request:

  • Add dry-run flag to kyma alpha create module to preventing push of module template

Related issue(s)

See: https://github.tools.sap/kyma/test-infra/issues/469

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 29, 2024
@CLAassistant
Copy link

CLAassistant commented Nov 29, 2024

CLA assistant check
All committers have signed the CLA.

@kyma-bot kyma-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cla: yes Indicates the PR's author has signed the CLA. labels Nov 29, 2024
@KacperMalachowski KacperMalachowski changed the title Add dry-run flag to prevent pushing module template to registry feat: Add dry-run flag to prevent pushing module template to registry Nov 29, 2024
@KacperMalachowski KacperMalachowski marked this pull request as ready for review November 29, 2024 11:27
@KacperMalachowski KacperMalachowski requested review from a team as code owners November 29, 2024 11:27
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 29, 2024
@Sawthis
Copy link

Sawthis commented Dec 3, 2024

@nesmabadr could you revert kyma-project/template-operator#226? It breaks the tests and we still use kyma cli on the submission pipeline.

CC: @kyma-project/otters

@Sawthis
Copy link

Sawthis commented Dec 3, 2024

@kyma-bot kyma-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 3, 2024
@KacperMalachowski
Copy link
Author

KacperMalachowski commented Dec 3, 2024

FIxing the e2e tests (at least at level of my knowledge for cli) without breaking it require code breaking change of: https://github.com/kyma-project/cli/blob/release-2.20/pkg/module/kubebuilder/project.go#L21

I really doubt if we can safely fix it for now in code, I can change it in the way it will use older version of template operator module. Question if it's fine for @kyma-project/otters ?
CC: @Sawthis

@halamix2 halamix2 merged commit 817a55d into kyma-project:release-2.20 Dec 4, 2024
4 of 9 checks passed
@KacperMalachowski KacperMalachowski deleted the add-dry-run branch December 4, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants