feat: Introduce Mandatory Module Deletion Service #2818
Conversation
LeelaChacha
changed the title
| "github.com/kyma-project/lifecycle-manager/api/v1beta2" | ||
| ) | ||
|
|
||
| type UseCase interface { |
There was a problem hiding this comment.
But not so sure if the ShouldExecute is needed.
You could just Execute the usecase and return the same errors or nil as Should Execute. Feels like a unnecessary indirection.
Usecases are anyways not very complex and mostly pass through to repos.
There was a problem hiding this comment.
We can talk about it in detail tomorrow in the office. @LeelaChacha is coming as well.
But the basic idea was that per invocation of the reconciliation loop, only one use case is executed. E.g., if ensureFinalizer should execute, we will apply the finalizer and return to the controller. Only in the next invocation of the reconciliation loop another use case may execute consecutively.
There was a problem hiding this comment.
:) No need, I got the idea. 👍
There was a problem hiding this comment.
Then just as a small improvement suggestion, let's rename to the following:
// IsApplicable checks if this deletion step use-case should be executed now
IsApplicable(ctx context.Context, mrm *v1beta2.ModuleReleaseMeta) (bool, error)
| "github.com/kyma-project/lifecycle-manager/api/v1beta2" | ||
| ) | ||
|
|
||
| type UseCase interface { |
There was a problem hiding this comment.
Then just as a small improvement suggestion, let's rename to the following:
// IsApplicable checks if this deletion step use-case should be executed now
IsApplicable(ctx context.Context, mrm *v1beta2.ModuleReleaseMeta) (bool, error)
Co-authored-by: Benjamin Lindner <[email protected]>
3 participants
Description
Changes proposed in this pull request:
Related issue(s)
#2631