Skip to content

Conversation

@c-pius
Copy link
Contributor

@c-pius c-pius commented Nov 27, 2025

Description

Changes proposed in this pull request:

  • Implements UseCase for Deleting SKR CRDs
  • provides instances for ModuleTemplate, ModuleReleaseMeta and Kyma CRDs to the deletion service

Related issue(s)

@c-pius c-pius requested a review from a team as a code owner November 27, 2025 15:04
@c-pius c-pius linked an issue Nov 27, 2025 that may be closed by this pull request
3 tasks
@c-pius c-pius requested a review from lindnerby November 27, 2025 15:07
@c-pius
Copy link
Contributor Author

c-pius commented Nov 27, 2025

The only CRD we managed left at the SKR after this use case is the Kyma one. I was first planning on having a separate use case for this one but now thinking about it, actually I would merge them together. So DeleteSkrModuleMetadata would become a DeleteSkrCrds. WDYT?

@lindnerby
Copy link
Member

The only CRD we managed left at the SKR after this use case is the Kyma one. I was first planning on having a separate use case for this one but now thinking about it, actually I would merge them together. So DeleteSkrModuleMetadata would become a DeleteSkrCrds. WDYT?

How about we try with even further granularity and try with one usecase per CRD, with Kyma last so in the events we would also have this distinction. If it figures this is taking too many reconciliations until final deletion we can still combine usecases into one very easily.

@c-pius
Copy link
Contributor Author

c-pius commented Nov 28, 2025

How about we try with even further granularity and try with one usecase per CRD, with Kyma last so in the events we would also have this distinction. If it figures this is taking too many reconciliations until final deletion we can still combine usecases into one very easily.

Done. Example of the events (warning one will be resolved in the other PR):

image

@c-pius c-pius requested a review from lindnerby November 28, 2025 13:39
@c-pius c-pius changed the title feat: UseCase DeleteSkrModuleMetadata feat: UseCase DeleteSkrCrds with instances for MT, MRM, Kyma Nov 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement a dedicated service for handling Kyma deprovisioning

2 participants