Skip to content

chore: Refine and test deletion service #2897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: feat/kyma-deletion-service
Choose a base branch
from
Open

chore: Refine and test deletion service #2897

wants to merge 2 commits into from

Conversation

@c-pius
Copy link
Contributor

@c-pius c-pius commented Nov 27, 2025

Description

Changes proposed in this pull request:

  • Refines the DeletionService to:
    • include the UseCase name if IsApplicable fails
    • include a default UseCase name on fall through (otherwise the event name would be empty)
  • Adds unit tests for the DeletionService

Related issue(s)

@c-pius c-pius requested a review from a team as a code owner November 27, 2025 16:20
@c-pius c-pius changed the title Chore/refine and test deletion service chore: Refine and test deletion service Nov 27, 2025
@c-pius c-pius requested a review from lindnerby November 27, 2025 16:20
@c-pius c-pius linked an issue Nov 28, 2025 that may be closed by this pull request
Implement a dedicated service for handling Kyma deprovisioning #2446
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lindnerby lindnerby Awaiting requested review from lindnerby

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement a dedicated service for handling Kyma deprovisioning

1 participant

@c-pius