Skip to content

Conversation

@TeodorSAP
Copy link
Member

@TeodorSAP TeodorSAP commented Jan 22, 2026

Description

Changes proposed in this pull request (what was done and why):

  • Implement configurable enrichment strategy behavior through custom annotation
  • Add tip in user docs
  • Add golden file tests
  • Refactor some existing e2e tests
  • Implement e2e tests for the new otel enrichment strategy
  • Refactor reconcilers' code to avoid duplicated functions
  • Simplify update-golden-files Make target

Changes refer to particular issues, PRs or documents:

Traceability

  • The PR is linked to a GitHub issue.
  • The follow-up issues (if any) are linked in the Related Issues section.
  • If the change is user-facing, the documentation has been adjusted.
  • If a CRD is changed, the corresponding Busola ConfigMap has been adjusted.
  • The feature is unit-tested.
  • The feature is e2e-tested.

@TeodorSAP TeodorSAP requested a review from a team as a code owner January 22, 2026 08:39
@TeodorSAP TeodorSAP added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/logs LogPipeline area/metrics MetricPipeline area/traces TracePipeline labels Jan 22, 2026
@TeodorSAP TeodorSAP added this to the 1.57.0 milestone Jan 22, 2026
@github-actions github-actions bot added kind/feature Categorizes issue or PR as related to a new feature. labels Jan 22, 2026
@TeodorSAP TeodorSAP enabled auto-merge (squash) January 22, 2026 09:59
@TeodorSAP TeodorSAP requested a review from a team as a code owner January 22, 2026 10:56
Copy link
Contributor

@NHingerl NHingerl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unclear situation whether the feature is already now discouraged (= deprecated) or not. If it's deprecated, let's tackle a deprecation note, which should accompany the update within this doc.
If it's not deprecated yet, this document should not informally act as a pre-deprecation.

@TeodorSAP TeodorSAP removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 23, 2026
@jeffreylimnardy jeffreylimnardy self-assigned this Jan 23, 2026
@TeodorSAP
Copy link
Member Author

Unclear situation whether the feature is already now discouraged (= deprecated) or not. If it's deprecated, let's tackle a deprecation note, which should accompany the update within this doc. If it's not deprecated yet, this document should not informally act as a pre-deprecation.

I agreed with your initial suggestion to just have it as a tip/option for now. We will make this message stronger in the following phases of the deprecation process, when the default behavior actually changes.

@TeodorSAP TeodorSAP added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 23, 2026
NHingerl
NHingerl previously approved these changes Jan 26, 2026
@TeodorSAP TeodorSAP removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 26, 2026
@TeodorSAP TeodorSAP requested a review from NHingerl January 26, 2026 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/logs LogPipeline area/metrics MetricPipeline area/traces TracePipeline kind/feature Categorizes issue or PR as related to a new feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Align Service Name enrichment: Activatable new enrichment logic

3 participants