feat: support narrowing by deep object keys in NarrowPartial#1667
Open
ethanresnick wants to merge 1 commit intokysely-org:masterfrom
Open
feat: support narrowing by deep object keys in NarrowPartial#1667ethanresnick wants to merge 1 commit intokysely-org:masterfrom
ethanresnick wants to merge 1 commit intokysely-org:masterfrom
Conversation
|
@ethanresnick is attempting to deploy a commit to the Kysely Team Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for narrowing by deep object keys in the NarrowPartial type utility, enabling more powerful type narrowing capabilities for nested structures like discriminated unions within JSON columns.
Key Changes:
- Enhanced
NarrowPartialtype to recursively narrow nested object properties - Added comprehensive test coverage for discriminated union narrowing
- Added missing type assertion for existing test case r15
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/util/type-utils.ts | Refactored NarrowPartial to support recursive narrowing of nested objects through intersection with recursive NarrowPartial calls |
| test/typings/test-d/select.test-d.ts | Added test for narrowing discriminated unions at deep object levels and added missing expectType assertion for r15 |
| test/typings/shared.d.ts | Added discriminatedUnionProfile field to test data with a discriminated union type for testing the new narrowing capability |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ethanresnick
force-pushed
the
deep-narrow
branch
from
409374b to
861136e
Compare
Contributor
Author
|
@igalklebanov This should be ready to go now, I think 🤞 |
ethanresnick
force-pushed
the
deep-narrow
branch
3 times, most recently
from
f584f6c to
472ab98
Compare
ethanresnick
force-pushed
the
deep-narrow
branch
from
472ab98 to
cba05e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reopening #1526 , but will fix the tests.