Conversation
l2hyunwoo
force-pushed
the
feat/add-publish-workflow
branch
from
73507d9 to
d8ded60
Compare
l2hyunwoo
force-pushed
the
feat/add-cache-ci
branch
from
9b65864 to
6d7abc9
Compare
l2hyunwoo
force-pushed
the
feat/add-cache-ci
branch
from
6d7abc9 to
fd15d6f
Compare
l2hyunwoo
added a commit
that referenced
this pull request
Dec 1, 2025
Address PR review comment #3: The comment "Found IPv4, return immediately" was misleading since the code doesn't return - it stores the address and continues iterating. Changed to "Found IPv4, store it" to match the actual behavior and maintain consistency with queryIpAddressInternal().
l2hyunwoo
added a commit
that referenced
this pull request
Dec 1, 2025
* fix(ios): prioritize IPv4 over IPv6 in getIpAddress() * fix(ios): add nil guard for interface in getIpAddress() Address PR review comment #5: The force unwrap of interface?.ifa_name could crash if interface is nil. Use guard statement to safely unwrap the interface before accessing its properties. * fix(ios): add nil guard for ifa_addr to prevent crash Address PR review comments #1 and #4: ifa_addr can be nil if the interface has no address assigned. According to Apple Developer Forums and the getifaddrs man page, this is a valid scenario that must be handled. Add guard statement to safely check ifa_addr before accessing its properties in both getIpAddress() and queryIpAddressInternal(). * fix(ios): correct misleading comment in getIpAddress() Address PR review comment #3: The comment "Found IPv4, return immediately" was misleading since the code doesn't return - it stores the address and continues iterating. Changed to "Found IPv4, store it" to match the actual behavior and maintain consistency with queryIpAddressInternal(). * fix(ios): return 'unknown' instead of empty string for IP address Address PR review comment #2: The API contract in TypeScript documentation (src/DeviceInfo.nitro.ts:954) specifies "@returns IP address string or 'unknown'". Changed return values from "" to "unknown" in both getIpAddress() and queryIpAddressInternal() to maintain backward compatibility and API consistency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.