Skip to content

feat: system language + navigation#32

Merged
l2hyunwoo merged 5 commits intomainfrom
feat/system-language-navigation
Nov 28, 2025
Merged

feat: system language + navigation#32
l2hyunwoo merged 5 commits intomainfrom
feat/system-language-navigation

Conversation

@l2hyunwoo
Copy link
Owner

@l2hyunwoo l2hyunwoo commented Nov 28, 2025

스크린샷 2025-11-29 오전 12 09 03

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds system language detection and Android navigation mode detection capabilities to the device info module. The new features provide access to the device's system language in BCP 47 format and the Android navigation mode (gesture, 2-button, or 3-button).

  • Added systemLanguage property to get device language in BCP 47 format on both iOS and Android
  • Added navigationMode property to detect Android navigation mode (returns 'unknown' on iOS)
  • Updated documentation with comprehensive examples and usage patterns

Reviewed changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/DeviceInfo.nitro.ts Added NavigationMode type and interface properties for systemLanguage and navigationMode
ios/DeviceInfo.swift Implemented systemLanguage using Locale.preferredLanguages and navigationMode returning 'unknown'
android/src/main/java/com/margelo/nitro/nitrodeviceinfo/DeviceInfo.kt Implemented systemLanguage using Locale and navigationMode using Settings.Secure
example/showcase/src/types/index.ts Added LOCALIZATION_NAVIGATION category enum
example/showcase/src/config/propertyCategories.ts Added property configurations for new features
docs/docs/api/types.md Added NavigationMode type documentation with examples
docs/docs/api/device-info.md Added comprehensive documentation for both new properties
example/showcase/ios/Podfile.lock Updated NitroDeviceInfo version from 1.1.0 to 1.2.1

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@l2hyunwoo l2hyunwoo changed the title feat: system language navigation feat: system language + navigation Nov 28, 2025
@l2hyunwoo l2hyunwoo merged commit 2ea0d5a into main Nov 28, 2025
8 checks passed
@l2hyunwoo l2hyunwoo deleted the feat/system-language-navigation branch November 28, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants