Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds system language detection and Android navigation mode detection capabilities to the device info module. The new features provide access to the device's system language in BCP 47 format and the Android navigation mode (gesture, 2-button, or 3-button).
- Added
systemLanguageproperty to get device language in BCP 47 format on both iOS and Android - Added
navigationModeproperty to detect Android navigation mode (returns 'unknown' on iOS) - Updated documentation with comprehensive examples and usage patterns
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/DeviceInfo.nitro.ts | Added NavigationMode type and interface properties for systemLanguage and navigationMode |
| ios/DeviceInfo.swift | Implemented systemLanguage using Locale.preferredLanguages and navigationMode returning 'unknown' |
| android/src/main/java/com/margelo/nitro/nitrodeviceinfo/DeviceInfo.kt | Implemented systemLanguage using Locale and navigationMode using Settings.Secure |
| example/showcase/src/types/index.ts | Added LOCALIZATION_NAVIGATION category enum |
| example/showcase/src/config/propertyCategories.ts | Added property configurations for new features |
| docs/docs/api/types.md | Added NavigationMode type documentation with examples |
| docs/docs/api/device-info.md | Added comprehensive documentation for both new properties |
| example/showcase/ios/Podfile.lock | Updated NitroDeviceInfo version from 1.1.0 to 1.2.1 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.