fix(android): prevent crash in getHasGms() when play-services-base is missing#42
Merged
fix(android): prevent crash in getHasGms() when play-services-base is missing#42
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a crash in getHasGms() when the play-services-base dependency is not included in an Android app. The fix changes the exception handling to catch Throwable instead of just Exception, which allows the method to gracefully handle NoClassDefFoundError and return false instead of crashing.
Key Changes:
- Modified exception handling from
catch (e: Exception)tocatch (e: Throwable)to catchNoClassDefFoundError - Changed log level from
Log.w(warning) toLog.d(debug) as missing GMS is an expected scenario - Enhanced documentation with detailed comments explaining the rationale
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
android/src/main/java/com/margelo/nitro/nitrodeviceinfo/DeviceInfo.kt
Outdated
Show resolved
Hide resolved
…hrowable Address PR review feedback: catching Throwable is too broad and can mask serious JVM errors like OutOfMemoryError or StackOverflowError. Now catches Exception and NoClassDefFoundError separately for more explicit error handling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
close #40
Summary
Fixes
getHasGms()to gracefully returnfalseinstead of crashing whenplay-services-basedependency is not included in the app.Problem
When an Android app does not include the
play-services-basedependency, callinggetHasGms()would crash with a JNI exception. This occurred because:GoogleApiAvailability.getInstance()throwsNoClassDefFoundErrorwhen the class cannot be loadedNoClassDefFoundErrorextendsError, notExceptioncatch (e: Exception)block did not catchErrortypesSolution
Changed error handling from
catch (e: Exception)tocatch (e: Throwable)to catch all error types includingNoClassDefFoundError.Also changed log level from Log.w (warning) to Log.d (debug) since missing GMS is an expected scenario for apps distributed on non-GMS stores.