Skip to content

add most common BPM to stats BPM #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ILW8 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add most common BPM to stats BPM #224

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a944df
add most common BPM
ILW8 Dec 9, 2023
1191566
revert autoformatting changes
ILW8 Dec 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions memory/values.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,8 +191,9 @@ type stats struct {
}

type bpm struct {
Minimal int `json:"min"`
Maximal int `json:"max"`
Minimal int `json:"min"`
Maximal int `json:"max"`
MostCommon int `json:"mostCommon"`
}

type path struct {
Expand Down
39 changes: 39 additions & 0 deletions pp/pp.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,11 @@ func readData(data *PP, ez C.ezpp_t, needStrain bool, path string) error {
C.ezpp_set_nmiss(ez, 0)
memory.MenuData.Bm.Stats.BeatmapMaxCombo = int32(C.ezpp_max_combo(ez))
memory.MenuData.Bm.Stats.FullSR = cast.ToFloat32(fmt.Sprintf("%.2f", float32(C.ezpp_stars(ez))))
type timingPoint struct {
time float64
msPerBeat float64
}
var timingPoints []timingPoint
var bpmChanges []int
var bpmMultiplier float64 = 1
if strings.Contains(memory.MenuData.Mods.PpMods, "DT") || strings.Contains(memory.MenuData.Mods.PpMods, "NC") {
Expand All @@ -115,12 +120,46 @@ func readData(data *PP, ez C.ezpp_t, needStrain bool, path string) error {
msPerBeat := float64(C.ezpp_timing_ms_per_beat(ez, C.int(i)))
timingChanges := int(C.ezpp_timing_change(ez, C.int(i)))
if timingChanges == 1 {
timingPoints = append(timingPoints, timingPoint{
time: float64(C.ezpp_timing_time(ez, C.int(i))),
msPerBeat: msPerBeat,
})

bpmFormula := int(math.Round(1 / msPerBeat * 1000 * 60 * bpmMultiplier))
if bpmFormula > 0 {
bpmChanges = append(bpmChanges, bpmFormula)
}
}
}

// adapted from osu.Game.Beatmaps.Beatmap.GetMostCommonBeatLength() at revision 07da9d95 on ppy/osu
var beatLengthDurations = make(map[float64]float64)
var lastTime = float64(C.ezpp_time_at(ez, C.int(C.ezpp_nobjects(ez))-1))
for i, timingPoint := range timingPoints {
var currentTime float64 = 0
if i > 0 {
currentTime = timingPoint.time
}
var nextTime = lastTime
if i < len(timingPoints)-1 {
nextTime = timingPoints[i+1].time
}

var duration = nextTime - currentTime
var roundedMsPerBeat = math.Round(timingPoint.msPerBeat*1000) / 1000
beatLengthDurations[roundedMsPerBeat] += duration
}

var mostCommonMsPerBeat float64 = 0
var longestDuration float64 = 0
for msPerBeat, aggregateDuration := range beatLengthDurations {
if aggregateDuration > longestDuration {
longestDuration = aggregateDuration
mostCommonMsPerBeat = msPerBeat
}
}
var mostCommonBPM = int(math.Round(1 / mostCommonMsPerBeat * 1000 * 60 * bpmMultiplier))
memory.MenuData.Bm.Stats.BeatmapBPM.MostCommon = mostCommonBPM
memory.MenuData.Bm.Stats.BeatmapBPM.Minimal, memory.MenuData.Bm.Stats.BeatmapBPM.Maximal = minMax(bpmChanges)
strainArray = nil
seek := 0
Expand Down