CSAF clean up revision history #1438
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Hubtrick-Git
commented
Nov 21, 2025
Hubtrick-Git
commented
- added some minor improvements to the code regarding the revision history part of csaf
- added product ids to each revision history entry
timbastin
requested changes
Nov 21, 2025
|
|
||
| // retrieve artifact information from arbitrary json data from keys artifactNames and scannerID | ||
| jsonData := event.GetArbitraryJSONData() | ||
| artifact, ok := jsonData["artifactNames"].(string) |
Member
There was a problem hiding this comment.
I think this will break. Relying on untyped logic so much makes it hard to maintain. I am pretty sure, we are not setting it consistently...
| switch event.Type { | ||
| case dtos.EventTypeDetected: | ||
| return fmt.Sprintf("Detected vulnerability %s in package %s (%s).", *vuln.CVEID, *vuln.ComponentPurl, artifactNameString), nil | ||
| return fmt.Sprintf("Detected vulnerability %s in product %s.", *vuln.CVEID, productIDsString) |
Member
There was a problem hiding this comment.
Actually i preferred the way it was before...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.