Firebase Integration #48
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update: build gradle
danielgomezrico
suggested changes
Aug 4, 2022
fatihergin
reviewed
Aug 29, 2022
| @@ -37,9 +36,11 @@ android { | |||
| implementation 'com.segment.analytics.android:analytics:4.10.4' | |||
| implementation 'com.segment.analytics.android.integrations:amplitude:3.1.0' | |||
| implementation 'com.appsflyer:segment-android-integration:6.5.2' | |||
| implementation 'com.segment.analytics.android.integrations:firebase:2.3.3' | |||
There was a problem hiding this comment.
aar package should be preferred to not get resource not found errors:
implementation 'com.segment.analytics.android.integrations:firebase:2.3.3@aar'
please see: https://segment.com/docs/connections/destinations/catalog/firebase/#getting-started-on-android
Note: The Firebase SDK requires android resources which are available on aar packages. Use the aar package when adding the Segment-Firebase SDK.
|
Hello, is there any news about this PR? |
|
@danielgomezrico Will this ever be merged? |
|
Hi @0x0-14 @AbelTarazona, this is not merged because:
If you need to use it you could point your pubspec to this branch and use it (but be careful, maybe doing a fork and using your own is safer) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.