feat: support outer doc comments for naming matrix tests

[orhun]

Adds support for using outer doc comments (///) instead of
auto-generated tests names for parameterized matrix tests.

e.g. legacy compact syntax:

expected => [
        /// forty_two
        42,
        /// four
        2*3-2,
    ],
)]
fn test(expected: usize) { ... }

e.g. attribute syntax:

fn test(
    #[values(
        /// forty_two
        42,
        /// four
        2*3-2,
    )]
    expected: usize,
) { ... }

The generated test names will be values_1_len_forty_two and
values_2_len_four.

Fixes #320

[la10736]

Ok, it looks fine as POC. Just a note about description, I prefer something like All_present and No_data_file. I don't remember where the sanitization occurs but I hope we can find a good way to do it.

Of course, both unit and integration tests are missed, but it's a POC.

Last note: I'm on vacation till Jul 21th, so I can't review this PR till this date.

Thx

[orhun]

I prefer something like All_present and No_data_file

Good point, updated the PR!

I added an additional parameter to sanitize_ident for disabling whitepspace filtering (to not break the previous behavior) and now are turned into _.

Let me know if this solution is good enough!

both unit and integration tests are missed

I added an unit test in the vlist module. For the integration tests, where would be a good place? Maybe under rtest/tests somewhere? I'd appreciate some guidance there :D

I'm on vacation till Jul 21th, so I can't review this PR till this date.

All good, no rush :)

[la10736]

First of all thanks very much for your effort and please apologize me for my late review.

You had implement the parser just for the older and deprecated syntax https://docs.rs/rstest/latest/rstest/attr.rstest.html#old-compact-syntax but not for the newer one https://docs.rs/rstest/latest/rstest/attr.rstest.html#values-lists . Moreover you introduced a silly bug (maybe I should write an integration test for it).

Here a todo list

• Fix legacy parser
• Implement the parser for the newer syntax too (with some test unit)
• Add integration tests: expand matrix::use_args_attributes in rstest/tests/rstest/mod.rs for the newer syntax and matrix::happy_path for the older.
• Modify `#[values] documentation (just for the newer syntax is enough)
• Add a line in changelog file

[orhun]

I addressed the feedback, please have a look again!

[la10736]

It's a great job but two more things:

1. I would have test for both case: with and without doc comments
2. I guess that the changes to sanitize_ident are not necessary (add a boolean flag to a function is often far than the best). Can you try my proposed solution?

[orhun]

Thanks for the review. Made the changes, please have a look!

[la10736]

Great Job!! Thanks a Lot. Just last small thing: change the changelog not from change to add

[orhun]

all done!