fix: resolve issue building docker image #352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d167624 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
mvantellingen
force-pushed
the
fix/dockerfile
branch
from
1609153 to
8d3c2c3
Compare
mvantellingen
force-pushed
the
fix/dockerfile
branch
from
8d3c2c3 to
d167624
Compare
Merged
mvantellingen
pushed a commit
that referenced
this pull request
Nov 30, 2025
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @labdigital/commercetools-mock@2.61.0 ### Minor Changes - [#347](#347) [`c7683d2`](c7683d2) Thanks [@tleguijt](https://github.com/tleguijt)! - Add removeQuantity action for inventory entries ### Patch Changes - [#350](#350) [`cfbc4ac`](cfbc4ac) Thanks [@mvantellingen](https://github.com/mvantellingen)! - Update release process to use trusted publishing - [#352](#352) [`93cebc5`](93cebc5) Thanks [@mvantellingen](https://github.com/mvantellingen)! - Update build process for the docker version - [#350](#350) [`cfbc4ac`](cfbc4ac) Thanks [@mvantellingen](https://github.com/mvantellingen)! - update various depdendencies to resolve potential security issues Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the project's Docker and build setup to use newer Node and pnpm versions, improves Dockerfile security and efficiency, and introduces a
docker-compose.yamlfor easier local development. It also updates the build process to usetsdownfor server bundling, and adds a startup log message for better visibility.Build and Docker improvements:
node:22-alpineand pnpm to10.24.0, improving security and compatibility. Also, the Dockerfile now uses a non-rootnodeuser for better security, and sets proper ownership on files and directories (Dockerfile).tsdowninstead ofesbuild, aligning with the project's main build tool (package.json).packageManagerandenginesfields inpackage.jsonto require newer versions of pnpm and Node, ensuring consistency with the Docker environment (package.json).Development workflow enhancements:
docker-compose.yamlfile to simplify local development and deployment, exposing the server on port 8989 and setting up appropriate environment variables (docker-compose.yaml).Developer experience:
src/server.tsto indicate when and where the server is running, making it easier to verify successful startup (src/server.ts).