fix: generate IDs for addresses

.changeset/seven-ravens-like.md

@@ -0,0 +1,5 @@
+---
+"@labdigital/commercetools-mock": patch
+---
+
+Generate an ID for address when one has not been passed

src/repositories/business-unit.ts

@@ -211,15 +211,12 @@ class BusinessUnitUpdateHandler
 		}
 
 		const newAddress = createAddress(
-			address,
+			{ ...address, id: addressId },
 			context.projectKey,
 			this._storage,
 		);
 		if (newAddress) {
-			resource.addresses[existingAddressIndex] = {
-				...newAddress,
-				id: addressId,
-			};
+			resource.addresses[existingAddressIndex] = newAddress;
 		}
 	}
 

src/repositories/customer/actions.ts

@@ -118,16 +118,13 @@ export class CustomerUpdateHandler
 		);
 
 		const newAddress = createAddress(
-			address,
+			{ ...address, id: current.id },
 			context.projectKey,
 			this._storage,
 		);
 
 		if (newAddress) {
-			resource.addresses[oldAddressIndex] = {
-				id: addressId,
-				...newAddress,
-			};
+			resource.addresses[oldAddressIndex] = newAddress;
 		}
 	}
 

src/repositories/helpers.test.ts

@@ -0,0 +1,25 @@
+import type { BaseAddress } from "@commercetools/platform-sdk";
+import { describe, expect, test } from "vitest";
+import { InMemoryStorage } from "#src/storage/index.ts";
+import { createAddress } from "./helpers.ts";
+
+describe("Helpers", () => {
+	const storage = new InMemoryStorage();
+	const projectKey = "test-project";
+
+	describe("createAddress", () => {
+		test("should generate random id when id is not provided", () => {
+			const baseAddress: BaseAddress = {
+				country: "US",
+				streetName: "Test Street",
+				city: "Test City",
+			};
+
+			const result = createAddress(baseAddress, projectKey, storage);
+			expect(result).toBeDefined();
+			expect(result?.id).toBeDefined();
+			expect(typeof result?.id).toBe("string");
+			expect(result?.id).toMatch(/^[a-z0-9]{8}$/);
+		});
+	});
+});

src/repositories/helpers.ts

@@ -48,8 +48,13 @@ export const createAddress = (
 		throw new Error("Country is required");
 	}
 
+	// Generate a random 8-character alphanumeric string
+	// which is what addresses use instead of uuid
+	const generateRandomId = (): string =>
+		Math.random().toString(36).substring(2, 10).padEnd(8, "0");
 	return {
 		...base,
+		id: base.id ?? generateRandomId(),
 	};
 };
 

src/services/cart.test.ts

@@ -644,7 +644,10 @@ describe("Cart Update Actions", () => {
 			});
 		expect(response.status).toBe(200);
 		expect(response.body.version).toBe(2);
-		expect(response.body.billingAddress).toEqual(address);
+		expect(response.body.billingAddress).toEqual({
+			...address,
+			id: expect.any(String),
+		});
 	});
 
 	test("setCountry", async () => {
@@ -1187,6 +1190,7 @@ describe("Cart Update Actions", () => {
 		expect(response.body.version).toBe(3);
 		expect(response.body.billingAddress).toEqual({
 			...address,
+			id: expect.any(String),
 			custom: {
 				type: { typeId: "type", id: type.id },
 				fields: { foo: "bar" },