-
Notifications
You must be signed in to change notification settings - Fork 23
feat: implement order search functionality with pagination support #368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: ea54bd9 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
d464500 to
495c5d6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request adds order search functionality to the mock commercetools API, enabling clients to search for orders with pagination support. The implementation follows the existing pattern used for product search and introduces the necessary service, repository, and endpoint components.
- Implements a new
OrderSearchservice class for handling order search operations with pagination - Adds a
/searchPOST endpoint to theOrderServicefor client access - Refactors line item creation in
OrderRepositoryto use direct object returns with thesatisfiesoperator
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| src/orderSearch.ts | New file implementing the OrderSearch class with pagination support for order queries |
| src/services/order.ts | Adds the /search POST endpoint route and handler method to expose order search functionality |
| src/repositories/order/index.ts | Integrates OrderSearch service, adds search method delegation, and refactors line item creation for cleaner code |
| .changeset/proud-results-sort.md | Documents the new order search endpoint feature as a minor version change |
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @labdigital/[email protected] ### Minor Changes - [#368](#368) [`a91c04e`](a91c04e) Thanks [@demeyerthom](https://github.com/demeyerthom)! - Add order search endpoint functionality Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This pull request introduces support for the order search endpoint in the mock Commercetools API, allowing users to search for orders with pagination. It adds a new
OrderSearchservice, integrates it into the order repository and service, and exposes a new/searchroute for orders. Additionally, there are some minor code cleanups and refactoring in the order repository.Order search functionality:
OrderSearchclass insrc/orderSearch.tsto handle searching and paginating orders, returning results in the expected format.OrderSearchservice into theOrderRepository, including a newsearchmethod that delegates to the service. (Fb3d1219L40R40, src/repositories/order/index.tsR406-R412)/searchPOST endpoint in theOrderServiceto allow clients to search for orders. [1] [2]Code cleanup and refactoring:
OrderRepositoryby returning objects directly and using thesatisfiesoperator for type safety. [1] [2] [3] [4]