Conversation
Each printer/labeler now has a config class instance setting its specific properties.
…roperties Used named tuple Renamed width/height to be consistent
Move LABELER_DISTANCE_BETWEEN_PRINT_HEAD_AND_CUTTER_MM to device config
As the DPI or PPM (pixels per mm) is now a property of the printer. Move all calculations requiring this value to the labeler object. This will improve future support of different DPI printers
Device dependent margins/config
Update config for LabelManager 420P
Merge main into develop
Using a property here is indirect and pointless
Develop cleanup 1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We created the
developbranch as an offshoot of #54. Let's use this PR to keep an eye on the divergence and hopefully soon get them merged together again.