[CUB-5407] Support onSuccess and onError in workflow sendCommand action #700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ignatiusreza
requested changes
Dec 5, 2024
src/schemata/definitions/workflow-template/action-objects/send-command.yml
Outdated
Show resolved
Hide resolved
src/schemata/definitions/workflow-template/action-objects/send-command.yml
Outdated
Show resolved
Hide resolved
kgrhartlage
suggested changes
Dec 6, 2024
ignatiusreza
approved these changes
Dec 6, 2024
ignatiusreza
requested changes
Dec 7, 2024
ignatiusreza
approved these changes
Dec 10, 2024
There was a problem hiding this comment.
LGTM 👍
Review checklist according to SOP-13 & SOP-014
- Code is readable
- Test coverage is appropriate
- I manually tested the changes and checked that related capabilities do not have any regressions
- I confirmed that all specifications linked to the issue are fulfilled
- I checked newly added dependencies for their licenses
kgrhartlage
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CUB-5407
Description
Manual PR Checklist