Skip to content

Remove samples as supported resource #848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 19, 2025
Merged

Remove samples as supported resource #848

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1b5f135
Remove samples
kgrhartlage Sep 18, 2025
91c4aba
Build schema
kgrhartlage Sep 18, 2025
daeb6ba
Remove from update-resource definition
kgrhartlage Sep 18, 2025
5ac05af
Build schema
kgrhartlage Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions dist/workflow-step-template-schema.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 1 addition & 4 deletions dist/workflow-template-schema.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions src/__tests__/fixtures/workflow_templates/example.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,17 +86,17 @@ steps:

![music](https://source.unsplash.com/600x400/?music)
fields:
sample:
device:
type: relationship
resourceType: samples
resourceType: devices
target:
type: quantity
unit: mg
actual:
type: quantity
unit: mg
substeps:
- primary: Place the {{sample}} on the balance.
- primary: Tare the balance {{device}}.
description: |
Your fancy markdown body with formatting, images and what not else!
confirm: true
Expand Down
1 change: 0 additions & 1 deletion src/schemata/definitions/field-schema/relationship.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ properties:
- users
- devices
- measurements
- samples
- channels
- collections
- attachments
Expand Down
1 change: 0 additions & 1 deletion src/schemata/definitions/resource-tag.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ enum:
- ports
- protonotifications
- roles
- samples
- smart_views
- users
- versions
Expand Down
3 changes: 1 addition & 2 deletions src/schemata/definitions/workflow-template/action-objects/update-resource.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,6 @@ additionalProperties:
- dashboard
- export
- measurement
- sample
- workflow_step_template
- workflow_template
attributes:
Expand All @@ -85,7 +84,7 @@ examples:
id: workflow_run.data.id
type: workflow_run
attributes:
title: sampleField.name
title: deviceField.name
- update_resource:
id: balance.id
type: device
Expand Down
5 changes: 1 addition & 4 deletions src/workflow-step-template-schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2099,7 +2099,6 @@
"dashboard",
"export",
"measurement",
"sample",
"workflow_step_template",
"workflow_template"
]
Expand Down Expand Up @@ -2136,7 +2135,7 @@
"id": "workflow_run.data.id",
"type": "workflow_run",
"attributes": {
"title": "sampleField.name"
"title": "deviceField.name"
}
}
},
Expand Down Expand Up @@ -3933,7 +3932,6 @@
"users",
"devices",
"measurements",
"samples",
"channels",
"collections",
"attachments"
Expand Down Expand Up @@ -4234,7 +4232,6 @@
"ports",
"protonotifications",
"roles",
"samples",
"smart_views",
"users",
"versions",
Expand Down
5 changes: 1 addition & 4 deletions src/workflow-template-schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3251,7 +3251,6 @@
"dashboard",
"export",
"measurement",
"sample",
"workflow_step_template",
"workflow_template"
]
Expand Down Expand Up @@ -3288,7 +3287,7 @@
"id": "workflow_run.data.id",
"type": "workflow_run",
"attributes": {
"title": "sampleField.name"
"title": "deviceField.name"
}
}
},
Expand Down Expand Up @@ -4554,7 +4553,6 @@
"users",
"devices",
"measurements",
"samples",
"channels",
"collections",
"attachments"
Expand Down Expand Up @@ -4850,7 +4848,6 @@
"ports",
"protonotifications",
"roles",
"samples",
"smart_views",
"users",
"versions",
Expand Down