driver: usbvideodriver: add support for overlaying FPS #1710
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We encourage addition of multiple quality settings for USB Video
devices, but there is no easy way to get feedback how many frames per
second are actually processed on the receiver side, which could
influence which quality settings would be chosen for Labgrid, especially as connection over USB 2.0/USB 3.0 can impact what frame rates we can achieve.
To allow for an easy evaluation of video devices and how they're
connected, expose the newly added fps feature in USBVideoDriver as
--fps command line option.
Check that I indeed am able to get the framerate configured in the quality
Makes it easier to evaluate cameras/HDMI grabbers
I ran the command with and without --fps and with the different quality settings
hardware did you test with?
I tested against the Guermok HDMI grabber added in #1709
Checklist
The existing arguments aren't documented/test either. The `--fps`` is documented in the help text.