usbstoragedriver: Allow to define a different waiting medium timeout #1711
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emantor
reviewed
Aug 2, 2025
labgrid/driver/usbstoragedriver.py
Outdated
|
|
||
| def __attrs_post_init__(self): | ||
| super().__attrs_post_init__() | ||
| self._expect = PtxExpect(self) |
There was a problem hiding this comment.
This is totally unused, why was this added?
panicking
force-pushed
the
feature/usbstorage-driver-timeout
branch
from
f209948 to
ecb0d50
Compare
Emantor
reviewed
Aug 3, 2025
labgrid/driver/usbstoragedriver.py
Outdated
| WAIT_FOR_MEDIUM_TIMEOUT = 10.0 # s | ||
| timeout = attr.ib(default=0.0, validator=attr.validators.instance_of(float)) | ||
| default=10.0, | ||
| validator=attr.validators.instance_of(float)) |
There was a problem hiding this comment.
Two timeouts and two validators does not look like valid python code.
Emantor
reviewed
Aug 3, 2025
| @@ -39,15 +39,22 @@ class USBStorageDriver(Driver): | |||
| "NetworkUSBSDWireDevice", | |||
| }, | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Stray newline, please remove it.
Emantor
reviewed
Aug 3, 2025
| WAIT_FOR_MEDIUM_SLEEP = 0.5 # s | ||
| MOUNT_RETRIES = 5 | ||
|
|
||
| def __attrs_post_init__(self): | ||
| if self.timeout < 0.0: | ||
| raise ValueError("timeout must be positive") |
There was a problem hiding this comment.
This should be moved into the validation function for attrs.
Nice to have a way to define a timeout for usb storage driver if
it used after a usb switch. This will make this code more simpler
mux_driver = target.get_driver('LXAUSBMuxDriver')
mux_driver.set_links(['host-device'])
time.sleep(3) <-- avoid to use a new sleep here
usb = target.get_driver('USBStorageDriver')
assert usb.get_size() > 0
Signed-off-by: Michael Trimarchi <[email protected]>
panicking
force-pushed
the
feature/usbstorage-driver-timeout
branch
from
ecb0d50 to
6bf4032
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nice to have a way to define a timeout for usb storage driver if it used after a usb switch. This will make this code more simpler
mux_driver = target.get_driver('LXAUSBMuxDriver')
mux_driver.set_links(['host-device'])
time.sleep(3) <-- avoid to use a new sleep here
usb = target.get_driver('USBStorageDriver')
assert usb.get_size() > 0
Let's consider this as first interaction with the project. Could be that somenthing is missing here and there. It's more an RFC patch