feat: reduce work based on desired metrics#175
Open
sprsquish wants to merge 1 commit intolablabs:masterfrom
Open
feat: reduce work based on desired metrics#175sprsquish wants to merge 1 commit intolablabs:masterfrom
sprsquish wants to merge 1 commit intolablabs:masterfrom
Conversation
cde99c3 to
2539646
Compare
Author
|
@haad Can I get a look at this, please? Anything I can do to make it easier to review? |
Contributor
|
@sprsquish sorry end of the year is quite crazy |
Contributor
|
@sprsquish Ok I had a look through your code and it looks good just 2 points. Can you please update it and resolve conflicts and I think it would be great to document how to add new metrics right now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduce work based on desired metrics
Description
The most significant changes made are refactoring metrics management. The refactor serves to eliminate API calls for metrics that are not required. For instance, previously, if I did not want to expose r2 metrics, the exporter would only neglect to register the metric with Prometheus, but still make the graphql request. The refactored code puts the responsibility on each fetch function to determine if there's any need for the metrics it provides. If there is no need, it returns early without making any calls.
Type of Change
Testing
make pr-testsand all tests passCode Quality
Before Submitting
Please ensure you have completed the following before submitting your PR:
# Run comprehensive tests make pr-testsIf the above command fails, please fix the issues before submitting your PR.
Additional Notes
Add any other context about the pull request here.