feat(FR-873): set dashboard page as a default #3554

agatha197 · 2025-04-21T07:02:11Z

Rename `experimental_dashboard` to `classic_dashboard_page` with inverted logic

This PR renames the user setting experimental_dashboard to classic_dashboard_page and inverts its logic. The dashboard page is now the default view, and users can opt to use the classic summary page instead.

The change affects:

Router configuration in App.tsx
WebUISider menu item display logic
User settings definition and UI controls
All language translation files with updated descriptions

This change better reflects that the dashboard is now the standard view rather than an experimental feature, while still allowing users to switch back to the classic summary page if preferred.

Checklist:

Documentation
Minium required manager version
Specific setting for review (eg., KB link, endpoint or how to setup)
Minimum requirements to check during review
Test case(s) to demonstrate the difference of before/after

agatha197 · 2025-04-21T07:02:26Z

style(FR-1577): improve dashboard statistics display design and progress visualization #4427
feat(FR-1575): merge admin dashboard into user dashboard #4425
feat(FR-873): set dashboard page as a default #3554 👈 (View in Graphite)
feat(FR-1240): add agent statistics and resource monitoring capabilities #4344 : 1 other dependent PR (#4399 )
feat(FR-1531): add active agent list to admin dashboard page #4365
feat(FR-1530): Implement window focus check for automatic refresh interval #4358 : 1 other dependent PR (#4371 )
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

flow:merge-queue - adds this PR to the back of the merge queue
flow:hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has required the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

github-actions · 2025-04-21T07:03:55Z

Coverage report for `./react`

St.^❔	Category	Percentage	Covered / Total
🔴	Statements	4.65% (+0% 🔼)	532/11429
🔴	Branches	3.76% (+0% 🔼)	302/8022
🔴	Functions	2.88% (+0% 🔼)	102/3543
🔴	Lines	4.6% (+0% 🔼)	514/11169

Test suite run success

121 tests passing in 14 suites.

Report generated by 🧪jest coverage report action from 4f287da

Copilot

Pull Request Overview

This PR renames the experimental_dashboard setting to classic_dashboard_page, inverts its logic, and updates all related UI and translations so that the dashboard is the default, with an opt-in classic summary page.

Updated translation files with new DescClassicDashboardPage and menu key ClassicDashboardPage, removed obsolete DescClassicSessionLauncher
Replaced the experimental dashboard checkbox in UserSettingsPage with the new classic dashboard toggle
Updated useBAISetting hook, WebUISider menu logic, and App.tsx routing to use classic_dashboard_page

Reviewed Changes

Copilot reviewed 25 out of 25 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
resources/i18n/*/.json	Added `DescClassicDashboardPage` and `ClassicDashboardPage`, removed `DescClassicSessionLauncher`
react/src/pages/UserSettingsPage.tsx	Replaced experimental dashboard setting with classic dashboard toggle
react/src/hooks/useBAISetting.tsx	Added `classic_dashboard_page` to `UserSettings` interface
react/src/components/MainLayout/WebUISider.tsx	Inverted menu display based on `classic_dashboard_page`
react/src/App.tsx	Updated route guards to use `classic_dashboard_page`

Comments suppressed due to low confidence (1)

react/src/pages/UserSettingsPage.tsx:247

Add tests for the new classic_dashboard_page setting to verify that the checkbox correctly reflects and persists the default state, and that routing switches between dashboard and summary as expected.

          type: 'checkbox',

resources/i18n/en.json

react/src/App.tsx

nowgnuesLee

LGTM

yomybaby

It works properly. I have a suggestion. How about adding a group of settings for the classic feature, similar to an experimental group?

ironAiken2

Please check the failed CI job.

agatha197 · 2025-10-17T05:40:56Z

@ironAiken2 The jest test files are all passed when I tested them on local env. I think that's the graphite's error.

ironAiken2 · 2025-10-17T08:49:52Z

@agatha197 Error: Error: The process '/usr/bin/git' failed with exit code 128 error occurs; it seems something went wrong when switching branches in Graphite, preventing it from finding the branch. I'll skip this part and review the rest.

nowgnuesLee

I'm not sure why, but it's failing in GitHub Actions. Could you run gt sync once?

agatha197 · 2025-10-20T02:22:14Z

oh finally it works! It passed all tests!

nowgnuesLee

LGTM

ironAiken2

LGTM

yomybaby

LGTM

graphite-app · 2025-10-22T08:55:12Z

Merge activity

Oct 22, 8:55 AM UTC: yomybaby added this pull request to the Graphite merge queue.
Oct 22, 8:55 AM UTC: The Graphite merge queue couldn't merge this PR because it had merge conflicts.
Oct 22, 9:26 AM UTC: agatha197 added this pull request to the Graphite merge queue.
Oct 22, 9:28 AM UTC: Merged by the Graphite merge queue.

Resolves #3546 ([FR-873](https://lablup.atlassian.net/browse/FR-873)) ## Rename `experimental_dashboard` to `classic_dashboard_page` with inverted logic This PR renames the user setting `experimental_dashboard` to `classic_dashboard_page` and inverts its logic. The dashboard page is now the default view, and users can opt to use the classic summary page instead. The change affects: - Router configuration in App.tsx - WebUISider menu item display logic - User settings definition and UI controls - All language translation files with updated descriptions This change better reflects that the dashboard is now the standard view rather than an experimental feature, while still allowing users to switch back to the classic summary page if preferred. ![image.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/2HueYSdFvL8pOB5mgrUQ/83d03b46-701d-484f-97e4-73da95fe446c.png) **Checklist:** - [x] Documentation - [ ] Minium required manager version - [ ] Specific setting for review (eg., KB link, endpoint or how to setup) - [ ] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after [FR-873]: https://lablup.atlassian.net/browse/FR-873?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

github-actions bot assigned agatha197 Apr 21, 2025

github-actions bot added area:ux UI / UX issue. area:i18n Localization labels Apr 21, 2025

github-actions bot added the size:M 30~100 LoC label Apr 21, 2025

agatha197 force-pushed the feat_FR-873_/set-dashboard-page-as-a-default branch from 45855d8 to 995054c Compare July 15, 2025 09:53

github-actions bot added size:L 100~500 LoC and removed size:M 30~100 LoC labels Jul 15, 2025

agatha197 marked this pull request as ready for review July 15, 2025 09:54

Copilot AI review requested due to automatic review settings July 15, 2025 09:54

Copilot AI reviewed Jul 15, 2025

View reviewed changes

resources/i18n/en.json Show resolved Hide resolved

react/src/App.tsx Show resolved Hide resolved

agatha197 requested a review from nowgnuesLee July 16, 2025 01:02

nowgnuesLee approved these changes Jul 18, 2025

View reviewed changes

yomybaby requested changes Jul 28, 2025

View reviewed changes

agatha197 force-pushed the feat_FR-873_/set-dashboard-page-as-a-default branch from 995054c to af8709b Compare July 29, 2025 00:58

agatha197 requested a review from yomybaby July 29, 2025 00:58

agatha197 force-pushed the feat_FR-873_/set-dashboard-page-as-a-default branch from af8709b to 0ed6535 Compare August 4, 2025 01:31

agatha197 changed the base branch from main to graphite-base/3554 October 16, 2025 05:35

agatha197 force-pushed the feat_FR-873_/set-dashboard-page-as-a-default branch from 0ed6535 to 5800173 Compare October 16, 2025 05:36

agatha197 changed the base branch from graphite-base/3554 to feat_FR-1240_/admin-dashboard October 16, 2025 05:36

This was referenced Oct 16, 2025

feat(FR-1240): add agent statistics and resource monitoring capabilities #4344

Merged

feat(FR-1531): add active agent list to admin dashboard page #4365

Merged

refactor(FR-1240): refactor FR-1240 with agentStats query #4399

Closed

agatha197 requested a review from nowgnuesLee October 16, 2025 05:42

ironAiken2 requested changes Oct 17, 2025

View reviewed changes

agatha197 requested a review from ironAiken2 October 17, 2025 07:39

nowgnuesLee requested changes Oct 20, 2025

View reviewed changes

agatha197 requested a review from nowgnuesLee October 20, 2025 02:21

agatha197 force-pushed the feat_FR-1240_/admin-dashboard branch from 086b36f to c5b0ebc Compare October 20, 2025 08:03

agatha197 force-pushed the feat_FR-873_/set-dashboard-page-as-a-default branch from 49617a3 to 580aafe Compare October 20, 2025 08:03

nowgnuesLee approved these changes Oct 20, 2025

View reviewed changes

agatha197 force-pushed the feat_FR-1240_/admin-dashboard branch from c5b0ebc to 89dbeef Compare October 20, 2025 08:39

agatha197 force-pushed the feat_FR-873_/set-dashboard-page-as-a-default branch 2 times, most recently from 075d561 to 905e57a Compare October 20, 2025 08:56

agatha197 force-pushed the feat_FR-1240_/admin-dashboard branch from 89dbeef to 1a6808a Compare October 20, 2025 08:56

agatha197 changed the base branch from feat_FR-1240_/admin-dashboard to graphite-base/3554 October 21, 2025 04:31

agatha197 force-pushed the graphite-base/3554 branch from 1a6808a to 43826b2 Compare October 21, 2025 06:01

agatha197 force-pushed the feat_FR-873_/set-dashboard-page-as-a-default branch from 905e57a to 3134151 Compare October 21, 2025 06:01

agatha197 changed the base branch from graphite-base/3554 to feat_FR-1240_/admin-dashboard October 21, 2025 06:01

agatha197 force-pushed the feat_FR-1240_/admin-dashboard branch from 43826b2 to e59548e Compare October 21, 2025 06:13

agatha197 force-pushed the feat_FR-873_/set-dashboard-page-as-a-default branch from 3134151 to 202d296 Compare October 21, 2025 06:13

agatha197 mentioned this pull request Oct 21, 2025

feat(FR-1575): merge admin dashboard into user dashboard #4425

Merged

5 tasks

ironAiken2 approved these changes Oct 21, 2025

View reviewed changes

yomybaby force-pushed the feat_FR-873_/set-dashboard-page-as-a-default branch from 202d296 to 16b9c95 Compare October 21, 2025 09:17

yomybaby mentioned this pull request Oct 21, 2025

style(FR-1577): improve dashboard statistics display design and progress visualization #4427

Open

yomybaby approved these changes Oct 22, 2025

View reviewed changes

graphite-app bot changed the base branch from feat_FR-1240_/admin-dashboard to graphite-base/3554 October 22, 2025 08:56

agatha197 force-pushed the feat_FR-873_/set-dashboard-page-as-a-default branch from 16b9c95 to 0d8210e Compare October 22, 2025 09:24

agatha197 force-pushed the graphite-base/3554 branch from e59548e to 11f7d5a Compare October 22, 2025 09:24

agatha197 changed the base branch from graphite-base/3554 to main October 22, 2025 09:24

graphite-app bot force-pushed the feat_FR-873_/set-dashboard-page-as-a-default branch from 0d8210e to 4f287da Compare October 22, 2025 09:26

graphite-app bot merged commit 4f287da into main Oct 22, 2025
11 checks passed

graphite-app bot deleted the feat_FR-873_/set-dashboard-page-as-a-default branch October 22, 2025 09:28

vercel bot temporarily deployed to Production October 22, 2025 10:04 Inactive

feat(FR-873): set dashboard page as a default #3554

feat(FR-873): set dashboard page as a default #3554

Uh oh!

Conversation

agatha197 commented Apr 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rename experimental_dashboard to classic_dashboard_page with inverted logic

Uh oh!

agatha197 commented Apr 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

github-actions bot commented Apr 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage report for ./react

Test suite run success

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

nowgnuesLee left a comment

Choose a reason for hiding this comment

Uh oh!

yomybaby left a comment

Choose a reason for hiding this comment

Uh oh!

ironAiken2 left a comment

Choose a reason for hiding this comment

Uh oh!

agatha197 commented Oct 17, 2025

Uh oh!

ironAiken2 commented Oct 17, 2025

Uh oh!

nowgnuesLee left a comment

Choose a reason for hiding this comment

Uh oh!

agatha197 commented Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nowgnuesLee left a comment

Choose a reason for hiding this comment

Uh oh!

ironAiken2 left a comment

Choose a reason for hiding this comment

Uh oh!

yomybaby left a comment

Choose a reason for hiding this comment

Uh oh!

graphite-app bot commented Oct 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

agatha197 commented Apr 21, 2025 •

edited

Loading

Rename `experimental_dashboard` to `classic_dashboard_page` with inverted logic

agatha197 commented Apr 21, 2025 •

edited

Loading

github-actions bot commented Apr 21, 2025 •

edited

Loading

Coverage report for `./react`

agatha197 commented Oct 20, 2025 •

edited

Loading

graphite-app bot commented Oct 22, 2025 •

edited

Loading