Skip to content

Conversation

@yomybaby
Copy link
Member

@yomybaby yomybaby commented Jul 10, 2025

TL;DR

Enhanced the Reservoir feature with artifact detail pages and improved navigation using React Router.

What changed?

  • Added a dedicated route for artifact details (/reservoir/:artifactId) to enable direct linking to specific artifacts
  • Refactored the ReservoirArtifactDetail component to work with the new routing system
  • Moved common utility functions for status and type icons/colors to a separate utils file
  • Enhanced the artifact list to use React Router links instead of click handlers
  • Improved the version details display with a table layout instead of a list
  • Added support for source URLs with clickable links
  • Added visual indicators for installed and pulling versions
  • Improved date formatting for better readability

How to test?

  1. Navigate to the Reservoir page
  2. Click on any artifact to view its details
  3. Verify the URL changes to include the artifact ID
  4. Test the back button functionality
  5. Check that version information is displayed correctly in the table
  6. Verify that source links are clickable when available
  7. Test the pull functionality for different artifact versions

Why make this change?

This change improves the user experience by:

  • Enabling direct linking to specific artifacts (shareable URLs)
  • Providing a more consistent navigation pattern using React Router
  • Displaying more detailed version information in a clearer format
  • Making better use of visual indicators to show artifact status
  • Improving code organization by extracting common utility functions

@github-actions github-actions bot added the size:XL 500~ LoC label Jul 10, 2025
Copy link
Member Author

yomybaby commented Jul 10, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@yomybaby yomybaby force-pushed the feature/reservoir-mockup-ui branch from afaf6b2 to dfaddbb Compare August 14, 2025 01:57
@yomybaby yomybaby force-pushed the feature/reservoir-mockup-ui-detail-page branch from e52d727 to 6902094 Compare August 14, 2025 01:57
@nowgnuesLee nowgnuesLee force-pushed the feature/reservoir-mockup-ui-detail-page branch from 6902094 to d9c3b9f Compare August 18, 2025 01:15
@nowgnuesLee nowgnuesLee force-pushed the feature/reservoir-mockup-ui branch from dfaddbb to 9aa1595 Compare August 18, 2025 01:15
@nowgnuesLee nowgnuesLee force-pushed the feature/reservoir-mockup-ui branch from 9aa1595 to 2b2e1b4 Compare August 22, 2025 05:19
@nowgnuesLee nowgnuesLee force-pushed the feature/reservoir-mockup-ui-detail-page branch from d9c3b9f to 1084697 Compare August 22, 2025 05:19
@nowgnuesLee nowgnuesLee force-pushed the feature/reservoir-mockup-ui branch from 2b2e1b4 to de399cc Compare August 25, 2025 03:55
@nowgnuesLee nowgnuesLee force-pushed the feature/reservoir-mockup-ui-detail-page branch 2 times, most recently from 0b97860 to 01079f5 Compare August 26, 2025 04:40
@nowgnuesLee nowgnuesLee force-pushed the feature/reservoir-mockup-ui branch from de399cc to 4042158 Compare August 26, 2025 04:40
@nowgnuesLee nowgnuesLee changed the base branch from feature/reservoir-mockup-ui to graphite-base/3935 August 26, 2025 05:03
@nowgnuesLee nowgnuesLee changed the base branch from graphite-base/3935 to feature/reservoir-mockup-ui August 26, 2025 05:49
@nowgnuesLee nowgnuesLee force-pushed the feature/reservoir-mockup-ui branch from 4042158 to 9b19ce8 Compare August 26, 2025 08:33
@nowgnuesLee nowgnuesLee force-pushed the feature/reservoir-mockup-ui-detail-page branch from 01079f5 to 3df7a22 Compare August 26, 2025 08:33
@yomybaby yomybaby force-pushed the feature/reservoir-mockup-ui branch from 9b19ce8 to 08dc70f Compare September 1, 2025 10:09
@yomybaby yomybaby force-pushed the feature/reservoir-mockup-ui-detail-page branch from 3df7a22 to 3dab197 Compare September 1, 2025 10:09
@nowgnuesLee nowgnuesLee force-pushed the feature/reservoir-mockup-ui-detail-page branch from 3dab197 to 5c512ab Compare September 1, 2025 15:45
@nowgnuesLee nowgnuesLee force-pushed the feature/reservoir-mockup-ui-detail-page branch from 5c512ab to f12e958 Compare September 2, 2025 02:33
@nowgnuesLee nowgnuesLee force-pushed the feature/reservoir-mockup-ui branch from 08dc70f to 7c2c0d9 Compare September 2, 2025 02:33
@nowgnuesLee nowgnuesLee changed the base branch from feature/reservoir-mockup-ui to graphite-base/3935 September 2, 2025 08:29
@graphite-app graphite-app bot force-pushed the feature/reservoir-mockup-ui-detail-page branch from f12e958 to e2fc868 Compare September 3, 2025 03:02
@graphite-app graphite-app bot force-pushed the graphite-base/3935 branch from 7c2c0d9 to 6cb19b1 Compare September 3, 2025 03:02
@graphite-app graphite-app bot changed the base branch from graphite-base/3935 to feature/reservoir-mockup-ui September 3, 2025 03:02
@graphite-app graphite-app bot force-pushed the feature/reservoir-mockup-ui-detail-page branch from e2fc868 to be55c1b Compare September 3, 2025 03:02
@nowgnuesLee nowgnuesLee force-pushed the feature/reservoir-mockup-ui-detail-page branch from be55c1b to 5b126ef Compare September 3, 2025 04:58
@nowgnuesLee nowgnuesLee force-pushed the feature/reservoir-mockup-ui branch 2 times, most recently from 2e122fb to 9fb55a2 Compare September 4, 2025 04:48
@nowgnuesLee nowgnuesLee force-pushed the feature/reservoir-mockup-ui-detail-page branch from 5b126ef to 5665f67 Compare September 4, 2025 04:48
@nowgnuesLee nowgnuesLee force-pushed the feature/reservoir-mockup-ui branch from 9fb55a2 to e1bf4a0 Compare September 9, 2025 03:45
@nowgnuesLee nowgnuesLee force-pushed the feature/reservoir-mockup-ui-detail-page branch from 5665f67 to 85b7ef4 Compare September 9, 2025 03:45
@nowgnuesLee nowgnuesLee force-pushed the feature/reservoir-mockup-ui branch from e1bf4a0 to f0a1c39 Compare September 10, 2025 07:14
@nowgnuesLee nowgnuesLee force-pushed the feature/reservoir-mockup-ui-detail-page branch from 85b7ef4 to 79ff6a3 Compare September 10, 2025 07:14
@nowgnuesLee nowgnuesLee force-pushed the feature/reservoir-mockup-ui branch from f0a1c39 to 807052b Compare September 16, 2025 05:21
@nowgnuesLee nowgnuesLee force-pushed the feature/reservoir-mockup-ui-detail-page branch from 79ff6a3 to 3abc6f6 Compare September 16, 2025 05:21
@nowgnuesLee nowgnuesLee force-pushed the feature/reservoir-mockup-ui branch from 807052b to ae46dc8 Compare September 22, 2025 02:45
@nowgnuesLee nowgnuesLee force-pushed the feature/reservoir-mockup-ui-detail-page branch from 3abc6f6 to 12d80a9 Compare September 22, 2025 02:45
@nowgnuesLee nowgnuesLee force-pushed the feature/reservoir-mockup-ui-detail-page branch from 12d80a9 to dfe44d3 Compare September 22, 2025 11:22
@nowgnuesLee nowgnuesLee force-pushed the feature/reservoir-mockup-ui branch from ae46dc8 to b57d1d9 Compare September 22, 2025 11:22
@nowgnuesLee nowgnuesLee force-pushed the feature/reservoir-mockup-ui branch from b57d1d9 to 64b561a Compare September 23, 2025 07:18
@nowgnuesLee nowgnuesLee force-pushed the feature/reservoir-mockup-ui-detail-page branch from dfe44d3 to 65f4e59 Compare September 23, 2025 07:18
@yomybaby yomybaby changed the base branch from feature/reservoir-mockup-ui to graphite-base/3935 September 23, 2025 09:57
@yomybaby yomybaby closed this Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XL 500~ LoC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant