feat(FR-1409): implementing import and delete for revision #4230

nowgnuesLee · 2025-09-01T15:53:14Z

resolves #4190 (FR-1409)

Reservoir UI Enhancements

This PR enhances the Reservoir UI with improved artifact management capabilities:

Adds artifact cleanup functionality to remove versions that are no longer needed
Improves the artifact detail page with better version management
Adds cancel functionality for in-progress artifact pulls
Refactors components for better reusability and maintainability
Adds comprehensive i18n support for all new UI elements

Key Components Added:

BAIDeleteArtifactModal for removing artifact versions
BAIArtifactDescriptions for consistent artifact metadata display
BAIArtifactTypeTag and BAIArtifactStatusTag for consistent status visualization
BAIArtifactRevisionDownloadButton and BAIArtifactRevisionDeleteButton for version management
BAISelect, BAIBucketSelect, and BAIObjectStorageSelect for improved selection interfaces

Schema Changes:

Removed duplicate type definitions
Added new mutation cleanupArtifactRevisions to replace deleteArtifactRevisions
Added ReservoirRegistry types and related mutations
Simplified storage handling in artifact operations

Checklist:

Documentation
Minium required manager version
Specific setting for review
Minimum requirements to check during review
Test case(s) to demonstrate the difference of before/after

nowgnuesLee · 2025-09-01T15:53:42Z

feat(FR-1507): add a value to config.toml to enalbe reservoir page #4327
feat(FR-1499): implement delete and restore artifacts #4317
feat(FR-1496): update pulling artifact edge after import revisions #4313
feat(FR-1495): implement progress bar with bai notifiacation #4264
feat(FR-1409): implementing import and delete for revision #4230 👈 (View in Graphite)
feat(FR-1262): intergrated graphql for reservoir #4157
feat: Reservoir UI draft #3934 : 1 other dependent PR (#3935 )
feat(FR-1370): Property filter component for GraphQL v2 filter type #4170 : 1 other dependent PR (#3947 )
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

flow:merge-queue - adds this PR to the back of the merge queue
flow:hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has required the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

github-actions · 2025-09-01T15:54:41Z

Coverage report for `./packages/backend.ai-ui`

St.^❔	Category	Percentage	Covered / Total
🔴	Statements	52.42%	130/248
🔴	Branches	32.26%	80/248
🔴	Functions	35.09%	20/57
🔴	Lines	54.84%	119/217

Test suite run success

55 tests passing in 3 suites.

Report generated by 🧪jest coverage report action from 3aca6b9

github-actions · 2025-09-02T02:35:04Z

Coverage report for `./react`

St.^❔	Category	Percentage	Covered / Total
🔴	Statements	4.49% (+0.01% 🔼)	501/11157
🔴	Branches	3.64% (+0.01% 🔼)	285/7829
🔴	Functions	2.59% (+0% 🔼)	90/3475
🔴	Lines	4.47% (+0.01% 🔼)	487/10907

Test suite run success

114 tests passing in 13 suites.

Report generated by 🧪jest coverage report action from 3aca6b9

packages/backend.ai-ui/src/components/fragments/BAIPullingArtifactRevisionAlert.tsx

yomybaby

LGTM

graphite-app · 2025-09-25T09:00:46Z

Merge activity

Sep 25, 9:00 AM UTC: yomybaby added this pull request to the Graphite merge queue.
Sep 25, 9:06 AM UTC: Merged by the Graphite merge queue.

resolves #4190 (FR-1409) # Reservoir UI Enhancements This PR enhances the Reservoir UI with improved artifact management capabilities: - Adds artifact cleanup functionality to remove versions that are no longer needed - Improves the artifact detail page with better version management - Adds cancel functionality for in-progress artifact pulls - Refactors components for better reusability and maintainability - Adds comprehensive i18n support for all new UI elements ## Key Components Added: - `BAIDeleteArtifactModal` for removing artifact versions - `BAIArtifactDescriptions` for consistent artifact metadata display - `BAIArtifactTypeTag` and `BAIArtifactStatusTag` for consistent status visualization - `BAIArtifactRevisionDownloadButton` and `BAIArtifactRevisionDeleteButton` for version management - `BAISelect`, `BAIBucketSelect`, and `BAIObjectStorageSelect` for improved selection interfaces ## Schema Changes: - Removed duplicate type definitions - Added new mutation `cleanupArtifactRevisions` to replace `deleteArtifactRevisions` - Added `ReservoirRegistry` types and related mutations - Simplified storage handling in artifact operations **Checklist:** - [x] Documentation - [ ] Minium required manager version - [ ] Specific setting for review - [ ] Minimum requirements to check during review - [ ] Test case(s) to demonstrate the difference of before/after

github-actions bot assigned nowgnuesLee Sep 1, 2025

github-actions bot added area:ux UI / UX issue. area:i18n Localization size:XL 500~ LoC labels Sep 1, 2025

This was referenced Sep 1, 2025

feat: Reservoir UI draft #3934

Merged

feat: Reservoir detail page UI draft #3935

Closed

feat: Reservoir Audit log UI draft #3936

Closed

feat(FR-1262): intergrated graphql for reservoir #4157

Merged

nowgnuesLee changed the title ~~feat: implementing import and delete for revision~~ feat(FR-1409): implementing import and delete for revision Sep 1, 2025

nowgnuesLee marked this pull request as ready for review September 1, 2025 15:54

nowgnuesLee requested a review from yomybaby September 1, 2025 16:03

nowgnuesLee force-pushed the feat/import-delete-revision branch 2 times, most recently from c9d42bd to 08dd52e Compare September 2, 2025 02:33

nowgnuesLee force-pushed the feat/reservoir-grphql branch from 72baf49 to 006b666 Compare September 2, 2025 02:33

nowgnuesLee force-pushed the feat/import-delete-revision branch 3 times, most recently from 4d1efb5 to 242576c Compare September 2, 2025 08:30

github-actions bot added the area:lib Library and SDK related issue. label Sep 2, 2025

nowgnuesLee force-pushed the feat/reservoir-grphql branch from 006b666 to 642989f Compare September 3, 2025 04:58

nowgnuesLee force-pushed the feat/import-delete-revision branch 5 times, most recently from 1e8fc7e to c52c92c Compare September 4, 2025 04:26

nowgnuesLee force-pushed the feat/reservoir-grphql branch from 642989f to 7b9abcb Compare September 4, 2025 04:48

nowgnuesLee force-pushed the feat/import-delete-revision branch 2 times, most recently from 69a4397 to ad6829f Compare September 4, 2025 07:29

nowgnuesLee force-pushed the feat/import-delete-revision branch from 1dffa87 to 01fcc67 Compare September 22, 2025 04:16

nowgnuesLee force-pushed the feat/reservoir-grphql branch from d45d03d to ad057bf Compare September 22, 2025 04:16

nowgnuesLee force-pushed the feat/import-delete-revision branch from 01fcc67 to b9232a0 Compare September 22, 2025 04:19

nowgnuesLee force-pushed the feat/reservoir-grphql branch from ad057bf to e59b40a Compare September 22, 2025 11:22

nowgnuesLee force-pushed the feat/import-delete-revision branch from b9232a0 to 58c1c32 Compare September 22, 2025 11:22

nowgnuesLee mentioned this pull request Sep 22, 2025

feat(FR-1499): implement delete and restore artifacts #4317

Merged

5 tasks

nowgnuesLee force-pushed the feat/import-delete-revision branch from 58c1c32 to 5aedb3a Compare September 23, 2025 07:18

yomybaby force-pushed the feat/reservoir-grphql branch from 096d50d to 5cabe48 Compare September 23, 2025 09:57

yomybaby force-pushed the feat/import-delete-revision branch from 5aedb3a to 25530b2 Compare September 23, 2025 09:57

nowgnuesLee force-pushed the feat/import-delete-revision branch from 25530b2 to 1aeaa1b Compare September 23, 2025 15:25

nowgnuesLee mentioned this pull request Sep 23, 2025

feat(FR-1507): add a value to config.toml to enalbe reservoir page #4327

Merged

5 tasks

nowgnuesLee force-pushed the feat/reservoir-grphql branch from 5cabe48 to eb503f9 Compare September 25, 2025 04:20

nowgnuesLee force-pushed the feat/import-delete-revision branch from 1aeaa1b to bd95558 Compare September 25, 2025 04:20

yomybaby requested changes Sep 25, 2025

View reviewed changes

packages/backend.ai-ui/src/components/fragments/BAIPullingArtifactRevisionAlert.tsx Outdated Show resolved Hide resolved

packages/backend.ai-ui/src/components/fragments/BAIPullingArtifactRevisionAlert.tsx Outdated Show resolved Hide resolved

nowgnuesLee force-pushed the feat/import-delete-revision branch 2 times, most recently from dcea61c to 4d203b0 Compare September 25, 2025 06:30

nowgnuesLee requested a review from yomybaby September 25, 2025 06:36

yomybaby force-pushed the feat/reservoir-grphql branch from eb503f9 to e86d92d Compare September 25, 2025 08:33

yomybaby force-pushed the feat/import-delete-revision branch from 4d203b0 to 27c9bf6 Compare September 25, 2025 08:33

yomybaby approved these changes Sep 25, 2025

View reviewed changes

graphite-app bot force-pushed the feat/reservoir-grphql branch from e86d92d to 74b18be Compare September 25, 2025 09:01

graphite-app bot force-pushed the feat/import-delete-revision branch from 27c9bf6 to 3aca6b9 Compare September 25, 2025 09:02

Base automatically changed from feat/reservoir-grphql to main September 25, 2025 09:05

graphite-app bot merged commit 3aca6b9 into main Sep 25, 2025
9 checks passed

graphite-app bot deleted the feat/import-delete-revision branch September 25, 2025 09:06

github-pages bot had a problem deploying to github-pages September 25, 2025 09:06 Error

github-pages bot had a problem deploying to github-pages September 25, 2025 09:07 Error

vercel bot temporarily deployed to Production September 25, 2025 09:41 Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(FR-1409): implementing import and delete for revision #4230

feat(FR-1409): implementing import and delete for revision #4230

Uh oh!

nowgnuesLee commented Sep 1, 2025 •

edited

Loading

Uh oh!

nowgnuesLee commented Sep 1, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Sep 1, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Sep 2, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

yomybaby left a comment

Uh oh!

graphite-app bot commented Sep 25, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

feat(FR-1409): implementing import and delete for revision #4230

feat(FR-1409): implementing import and delete for revision #4230

Uh oh!

Conversation

nowgnuesLee commented Sep 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reservoir UI Enhancements

Key Components Added:

Schema Changes:

Uh oh!

nowgnuesLee commented Sep 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

github-actions bot commented Sep 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage report for ./packages/backend.ai-ui

Test suite run success

Uh oh!

github-actions bot commented Sep 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage report for ./react

Test suite run success

Uh oh!

Uh oh!

Uh oh!

yomybaby left a comment

Choose a reason for hiding this comment

Uh oh!

graphite-app bot commented Sep 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

nowgnuesLee commented Sep 1, 2025 •

edited

Loading

nowgnuesLee commented Sep 1, 2025 •

edited

Loading

github-actions bot commented Sep 1, 2025 •

edited

Loading

Coverage report for `./packages/backend.ai-ui`

github-actions bot commented Sep 2, 2025 •

edited

Loading

Coverage report for `./react`

graphite-app bot commented Sep 25, 2025 •

edited

Loading