-
Notifications
You must be signed in to change notification settings - Fork 78
feat(FR-1318): add button to start model service after cloning folder #4062
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements a button to start model services after cloning folders, introducing confirmation dialogs and validation for folder-based model service creation.
- Adds internationalization strings for clone confirmation and folder validation messages
- Implements folder definition file validation before service creation
- Modifies the model card modal to include the model service button
Reviewed Changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Multiple i18n files | Adds translation strings for folder clone confirmation dialogs and validation messages |
| ModelTryContentButton.tsx | Major refactoring to add folder validation, confirmation dialogs, and improved service creation flow |
| ModelCardModal.tsx | Re-enables the ModelTryContentButton in the modal footer |
| UserSettingsPage.tsx | Updates Antd API usage from bodyStyle to styles.body |
Comments suppressed due to low confidence (1)
react/src/components/ModelTryContentButton.tsx:109
- The notification redirect URL uses
data?.bgtask_idas theendpointId, but this should use the actual service endpoint ID from the service creation result. Background task ID and service endpoint ID are different values.
method: 'GET',
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 4.68% (-0.01% 🔻) |
532/11360 |
| 🔴 | Branches | 3.78% (-0.01% 🔻) |
302/7997 |
| 🔴 | Functions | 2.9% (+0% 🔼) |
102/3517 |
| 🔴 | Lines | 4.63% (-0.01% 🔻) |
514/11101 |
Test suite run success
121 tests passing in 14 suites.
Report generated by 🧪jest coverage report action from 58ed4db
0543a89 to
b0a90af
Compare
b0a90af to
31fcd9e
Compare
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 51.18% (-1.93% 🔻) |
130/254 |
| 🔴 | Branches | 32.79% (-0.41% 🔻) |
80/244 |
| 🔴 | Functions | 34.48% (-1.23% 🔻) |
20/58 |
| 🔴 | Lines | 53.36% (-2.04% 🔻) |
119/223 |
Show files with reduced coverage 🔻
St.❔ |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🟡 | helper/index.ts | 66.17% (-5.5% 🔻) |
46.98% (-0.97% 🔻) |
61.54% (-5.13% 🔻) |
70% (-6% 🔻) |
Test suite run success
55 tests passing in 3 suites.
Report generated by 🧪jest coverage report action from 2e63cf8
31fcd9e to
8a79014
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
8a79014 to
2e63cf8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2e63cf8 to
1397308
Compare
|
@ironAiken2 It is intended. The image will be set by service-definition.yaml |
fdec0b1 to
3dd1053
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check my reviews
3dd1053 to
fcfcf89
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check this review again.
https://app.graphite.dev/github/pr/lablup/backend.ai-webui/4062/feat(FR-1318)-add-button-to-start-model-service-after-cloning-folder#comment-PRRC_kwDOCRTcws6LX8tk
And resolve conflict ;)
a9056e2 to
2ecca83
Compare
2ecca83 to
735b8bb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is an issue where the service creation request keeps retrying indefinitely when the service creation fails.
8b45164 to
e50a9a8
Compare
- Add ModelTryContentButton to ModelCardModal with run model functionality - Implement folder cloning and service creation workflow - Add validation for model-definition.yaml and service-definition.toml files - Support both cloning new folders and using existing folders - Add proper error handling and user confirmation dialogs - Update internationalization files with new translation keys
e50a9a8 to
58ed4db
Compare


Resolves #4048 (FR-1318)
Summary
Adds a "Run This Model" button to the ModelCardModal that enables users to start model services immediately after cloning folders if no cloned folder exists. The implementation includes smart folder management, validation, and user confirmation workflows.
Changes
Core Implementation
modelCardMetadatadependency for cleanerinterface
files → create service
dialogs
Key Features
new cloning needs
service-definition.tomlandmodel-definition.yamlfilesusing existing folders
notifications for clone and service operations
files are missing or operations fail
UI Integration
modal footer
all language files
Technical Details
The component now follows this workflow:
with filters
Validate service definition → Create service
service definition → Create service
Test Plan
ModelCardModal