Skip to content

feat(FR-1507): add a value to config.toml to enalbe reservoir page #4327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 25, 2025
Merged

feat(FR-1507): add a value to config.toml to enalbe reservoir page #4327

merged 1 commit into from
Sep 25, 2025

Conversation

@nowgnuesLee
Copy link
Contributor

@nowgnuesLee nowgnuesLee commented Sep 23, 2025 •
edited
Loading

Add configuration option to enable/disable Reservoir page

resolves #4326 (FR-1507)

This PR adds a new configuration option enableReservoir to control the visibility of the Reservoir page in the UI. By default, this feature is disabled (false).

The changes include:

  • Adding the enableReservoir configuration option to the sample config file
  • Updating the WebUISider component to check this configuration before displaying the Reservoir menu item
  • Adding the configuration property to the BackendAIConfig type
  • Implementing the property in the login component and passing it to the client configuration

Checklist:

  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

@nowgnuesLee nowgnuesLee mentioned this pull request Sep 23, 2025
Merged
5 tasks
@github-actions github-actions bot added the size:S 10~30 LoC label Sep 23, 2025
This was referenced Sep 23, 2025
Merged
Merged
@nowgnuesLee Graphite App
Copy link
Contributor Author

nowgnuesLee commented Sep 23, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Sep 23, 2025
Merged
Merged
@nowgnuesLee nowgnuesLee marked this pull request as ready for review September 23, 2025 15:26
@github-actions
Copy link

github-actions bot commented Sep 23, 2025 •
edited
Loading

Coverage report for ./react

St.❔
 Category Percentage Covered / Total
🔴 Statements 4.47% 501/11215
🔴 Branches
3.63% (-0% 🔻)
 285/7850
🔴 Functions 2.57% 90/3501
🔴 Lines 4.44% 487/10964

Test suite run success

114 tests passing in 13 suites.

Report generated by 🧪jest coverage report action from 6e0ef12

@nowgnuesLee nowgnuesLee force-pushed the feat/delete-and-restore-artifacts branch from 5da3853 to 3185d5c Compare September 23, 2025 15:54
@nowgnuesLee nowgnuesLee force-pushed the feat/add-value-to-config-toml branch from d69d726 to b4981e6 Compare September 23, 2025 15:54
@nowgnuesLee nowgnuesLee force-pushed the feat/delete-and-restore-artifacts branch from 3185d5c to 5357af0 Compare September 23, 2025 15:57
@nowgnuesLee nowgnuesLee force-pushed the feat/add-value-to-config-toml branch from b4981e6 to a0c9bb9 Compare September 23, 2025 15:57
@nowgnuesLee nowgnuesLee force-pushed the feat/delete-and-restore-artifacts branch from 5357af0 to 35b4fc4 Compare September 24, 2025 00:07
@nowgnuesLee nowgnuesLee force-pushed the feat/add-value-to-config-toml branch 2 times, most recently from 068d2d4 to 98acf31 Compare September 24, 2025 00:42
@nowgnuesLee nowgnuesLee force-pushed the feat/delete-and-restore-artifacts branch 2 times, most recently from 5796a5c to 78e0e2d Compare September 25, 2025 01:25
@nowgnuesLee nowgnuesLee force-pushed the feat/add-value-to-config-toml branch from 98acf31 to 63afeac Compare September 25, 2025 01:25
@nowgnuesLee nowgnuesLee force-pushed the feat/delete-and-restore-artifacts branch from 78e0e2d to fa9f843 Compare September 25, 2025 04:20
@nowgnuesLee nowgnuesLee force-pushed the feat/add-value-to-config-toml branch 2 times, most recently from 064ccb3 to a561c8f Compare September 25, 2025 04:23
@nowgnuesLee nowgnuesLee force-pushed the feat/delete-and-restore-artifacts branch 2 times, most recently from cf95576 to ee2db40 Compare September 25, 2025 05:05
@nowgnuesLee nowgnuesLee force-pushed the feat/add-value-to-config-toml branch from a561c8f to 63c6dc7 Compare September 25, 2025 05:06
@nowgnuesLee nowgnuesLee force-pushed the feat/delete-and-restore-artifacts branch from ee2db40 to cb0e1f7 Compare September 25, 2025 05:32
@nowgnuesLee nowgnuesLee force-pushed the feat/add-value-to-config-toml branch from 63c6dc7 to 019d701 Compare September 25, 2025 05:32
@nowgnuesLee nowgnuesLee force-pushed the feat/delete-and-restore-artifacts branch from cb0e1f7 to ee60edb Compare September 25, 2025 06:20
@nowgnuesLee nowgnuesLee force-pushed the feat/add-value-to-config-toml branch 2 times, most recently from 9514368 to 289c0a8 Compare September 25, 2025 06:30
@nowgnuesLee nowgnuesLee force-pushed the feat/delete-and-restore-artifacts branch 2 times, most recently from b436c15 to 07358a1 Compare September 25, 2025 07:02
@nowgnuesLee nowgnuesLee force-pushed the feat/add-value-to-config-toml branch from 289c0a8 to b09bdfe Compare September 25, 2025 07:02
@yomybaby yomybaby force-pushed the feat/add-value-to-config-toml branch from b09bdfe to 7cf1356 Compare September 25, 2025 08:33
@yomybaby yomybaby force-pushed the feat/delete-and-restore-artifacts branch from 07358a1 to 7d45f5e Compare September 25, 2025 08:33
@yomybaby yomybaby force-pushed the feat/add-value-to-config-toml branch from 7cf1356 to 6151efa Compare September 25, 2025 08:42
@github-actions github-actions bot added size:M 30~100 LoC and removed size:S 10~30 LoC labels Sep 25, 2025
@github-actions
Copy link

github-actions bot commented Sep 25, 2025 •
edited
Loading

Coverage report for ./packages/backend.ai-ui

St.❔
 Category Percentage Covered / Total
🔴 Statements 52.42% 130/248
🔴 Branches 32.26% 80/248
🔴 Functions 35.09% 20/57
🔴 Lines 54.84% 119/217

Test suite run success

55 tests passing in 3 suites.

Report generated by 🧪jest coverage report action from 6e0ef12

yomybaby
yomybaby approved these changes Sep 25, 2025
View reviewed changes
Copy link
Member

@yomybaby yomybaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@graphite-app
Copy link

graphite-app bot commented Sep 25, 2025 •
edited
Loading

Merge activity

@nowgnuesLee
feat(FR-1507): add a value to config.toml to enalbe reservoir page (#…
6e0ef12 
…4327)

# Add configuration option to enable/disable Reservoir page

resolves #4326 (FR-1507)

This PR adds a new configuration option `enableReservoir` to control the visibility of the Reservoir page in the UI. By default, this feature is disabled (`false`).

The changes include:
- Adding the `enableReservoir` configuration option to the sample config file
- Updating the WebUISider component to check this configuration before displaying the Reservoir menu item
- Adding the configuration property to the BackendAIConfig type
- Implementing the property in the login component and passing it to the client configuration

**Checklist:**
- [ ] Documentation
- [ ] Minium required manager version
- [ ] Specific setting for review (eg., KB link, endpoint or how to setup)
- [ ] Minimum requirements to check during review
- [ ] Test case(s) to demonstrate the difference of before/after
@graphite-app graphite-app bot force-pushed the feat/delete-and-restore-artifacts branch from 7d45f5e to 780880d Compare September 25, 2025 09:04
@graphite-app graphite-app bot force-pushed the feat/add-value-to-config-toml branch from 6151efa to 6e0ef12 Compare September 25, 2025 09:04
Base automatically changed from feat/delete-and-restore-artifacts to main September 25, 2025 09:07
@graphite-app graphite-app bot merged commit 6e0ef12 into main Sep 25, 2025
9 checks passed
@graphite-app graphite-app bot deleted the feat/add-value-to-config-toml branch September 25, 2025 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yomybaby yomybaby yomybaby approved these changes

Assignees

@nowgnuesLee nowgnuesLee

Labels

size:M 30~100 LoC

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add a value to config.toml to enable reservoirPage

2 participants

@nowgnuesLee @yomybaby