fix(FR-1501): fix file upload status tracking and error handling #4412

ironAiken2 · 2025-10-20T05:09:59Z

Changes

This PR fixes file upload status tracking issues by refactoring the upload status data structure and improving progress tracking:

Key Changes

Refactored upload status structure
- Changed from simple arrays to objects with vFolderNames and totalSize properties
- Properly initialized completed and failed states to prevent "not iterable" errors
Enhanced progress tracking
- Added proper byte counting for upload progress
- Improved notification messages to show upload count (e.g., "5 / 10 files")
- Progress percentage now based on total bytes uploaded
Increased upload concurrency
- Changed PQueue concurrency from 1 to 10 for better performance
- Enables multiple files to upload simultaneously
Updated FolderExplorer
- Modified to work with new upload status structure

Files Changed

react/src/components/FileUploadManager.tsx - Main refactoring
react/src/components/FolderExplorer.tsx - Minor update for compatibility

Checklist:

Documentation
Minimum required manager version
Specific setting for review
Minimum requirements to check during review
Test case: Upload multiple files and verify status tracking works correctly

ironAiken2 · 2025-10-20T05:10:21Z

fix(FR-1501): fix file upload status tracking and error handling #4412 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

flow:merge-queue - adds this PR to the back of the merge queue
flow:hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has required the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

github-actions · 2025-10-20T05:12:31Z

Coverage report for `./react`

St.^❔	Category	Percentage	Covered / Total
🔴	Statements	4.65% (-0% 🔻)	532/11435
🔴	Branches	3.75% (-0.01% 🔻)	302/8044
🔴	Functions	2.88% (-0% 🔻)	102/3545
🔴	Lines	4.6% (-0% 🔻)	514/11174

Test suite run success

121 tests passing in 14 suites.

Report generated by 🧪jest coverage report action from e5745cb

Copilot

Pull Request Overview

Fixes inaccurate and fragile file upload status tracking by restructuring status data and improving progress calculation and notifications.

Introduces structured UploadStatus objects with vFolderNames and totalSize.
Adds byte-based progress and concurrent uploads (PQueue concurrency 10).
Adjusts FolderExplorer to new status shape.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File	Description
react/src/components/FolderExplorer.tsx	Updated empty-pending check to match new nested status structure.
react/src/components/FileUploadManager.tsx	Refactored data structures, progress computation, notification messaging, and concurrency.

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

react/src/components/FolderExplorer.tsx

Copilot · 2025-10-20T05:12:52Z

react/src/components/FileUploadManager.tsx

+                          bytesUploaded) /
+                          uploadRequests.totalBytes) *
+                          100,
+                      ) - 1,


Subtracting 1 causes percent to be -1 when progress starts (bytesUploaded = 0), yielding an invalid negative progress value. Remove the - 1 to keep percent within 0–100.

Suggested change

) - 1,

),

Since ant design's progress handle negative value to zero, I'll keep '-1' to prevent showing progress bar as complete (as green color).

Copilot · 2025-10-20T05:12:52Z

react/src/components/FileUploadManager.tsx

+              ...(prev[vFolderId]?.pending.vFolderNames || []),
+              ...uploadFilesNames,
+            ],
+            totalSize: uploadRequests.totalBytes,


Using uploadRequests.totalBytes (aggregate of all folders) for each vFolder's pending.totalSize and progress denominator produces incorrect per-folder percentages when multiple folders upload concurrently. Store per-request bytes (e.g. set uploadRequestInfo.totalBytes at creation) and use that request-specific total in both initialization and percent calculation.

Suggested change

totalSize: uploadRequests.totalBytes,

totalSize: uploadRequest.totalBytes ?? 0,

Copilot · 2025-10-20T05:12:52Z

react/src/components/FileUploadManager.tsx

+                    percent:
+                      Math.round(
+                        ((prev[vFolderId]?.completed.totalSize +
+                          bytesUploaded) /
+                          uploadRequests.totalBytes) *
+                          100,
+                      ) - 1,


Using uploadRequests.totalBytes (aggregate of all folders) for each vFolder's pending.totalSize and progress denominator produces incorrect per-folder percentages when multiple folders upload concurrently. Store per-request bytes (e.g. set uploadRequestInfo.totalBytes at creation) and use that request-specific total in both initialization and percent calculation.

agatha197

please apply copilot's reviews and resolve conflicts

react/src/components/FileUploadManager.tsx

github-actions bot assigned ironAiken2 Oct 20, 2025

github-actions bot added the size:L 100~500 LoC label Oct 20, 2025

ironAiken2 requested review from agatha197, nowgnuesLee and yomybaby October 20, 2025 05:11

ironAiken2 marked this pull request as ready for review October 20, 2025 05:12

Copilot AI review requested due to automatic review settings October 20, 2025 05:12

Copilot AI reviewed Oct 20, 2025

View reviewed changes

ironAiken2 force-pushed the fix/FR-1501-file-upload-status-tracking branch from d5cfaff to 3f7e879 Compare October 20, 2025 07:23

agatha197 requested changes Oct 22, 2025

View reviewed changes

react/src/components/FileUploadManager.tsx Outdated Show resolved Hide resolved

fix(FR-1501): fix file upload status tracking and error handling

e5745cb

ironAiken2 force-pushed the fix/FR-1501-file-upload-status-tracking branch from 3f7e879 to e5745cb Compare October 22, 2025 09:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(FR-1501): fix file upload status tracking and error handling #4412

fix(FR-1501): fix file upload status tracking and error handling #4412

ironAiken2 commented Oct 20, 2025 •

edited by atlassian bot

Loading

Uh oh!

ironAiken2 commented Oct 20, 2025

Uh oh!

github-actions bot commented Oct 20, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI Oct 20, 2025

Uh oh!

ironAiken2 Oct 22, 2025

Uh oh!

Copilot AI Oct 20, 2025

Uh oh!

Copilot AI Oct 20, 2025

Uh oh!

agatha197 left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	totalSize: uploadRequests.totalBytes,
	totalSize: uploadRequest.totalBytes ?? 0,

fix(FR-1501): fix file upload status tracking and error handling #4412

Are you sure you want to change the base?

fix(FR-1501): fix file upload status tracking and error handling #4412

Conversation

ironAiken2 commented Oct 20, 2025 • edited by atlassian bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Key Changes

Files Changed

Uh oh!

ironAiken2 commented Oct 20, 2025

How to use the Graphite Merge Queue

Uh oh!

github-actions bot commented Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coverage report for ./react

Test suite run success

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Copilot AI Oct 20, 2025

Choose a reason for hiding this comment

Uh oh!

ironAiken2 Oct 22, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 20, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 20, 2025

Choose a reason for hiding this comment

Uh oh!

agatha197 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ironAiken2 commented Oct 20, 2025 •

edited by atlassian bot

Loading

github-actions bot commented Oct 20, 2025 •

edited

Loading

Coverage report for `./react`