feat(FR-1426): conditionally show terminal guide based on copy feature support #4414
+6
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area:lib
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Pull Request Overview
This PR conditionally displays the terminal guide dialog based on whether the Backend.AI manager supports the new copy-on-terminal feature (version 25.13.2+). When the feature is supported, the guide dialog is suppressed since users can copy text directly via mouse selection in tmux, eliminating the need for instructional popup.
Key changes:
- Added
copy-on-terminalfeature flag for manager version 25.13.2+ - Modified terminal guide dialog to display only when copy-on-terminal is not supported
- Corrected placement of
reservoirfeature flag to version 25.12.0
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/lib/backend.ai-client-esm.ts | Added copy-on-terminal feature flag and repositioned reservoir flag to correct version block |
| src/components/backend-ai-app-launcher.ts | Added conditional check to show terminal guide only when copy-on-terminal is unsupported |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
agatha197
requested changes
Oct 28, 2025
ironAiken2
force-pushed
the
feat/FR-1426-conditional-terminal-guide
branch
from
208a6f7 to
b3cd91d
Compare
Merge activity
|
…e support (#4414) Resolves #4220 ([FR-1426](https://lablup.atlassian.net/browse/FR-1426)) ## Changes This PR implements conditional display of the terminal guide dialog based on the new copy-on-terminal feature support. ### Key Changes 1. **Added copy-on-terminal feature flag** - New feature flag for manager version 25.13.2+ - Indicates support for clipboard copy via mouse selection in tmux 2. **Conditional terminal guide display** - Terminal guide dialog now only shows when `copy-on-terminal` feature is NOT supported - Provides backward compatibility for older manager versions - Improves UX by removing unnecessary popup when copy feature is available 3. **Code organization** - Moved `reservoir` feature flag to correct version section (25.12.0) ### Files Changed - `src/components/backend-ai-app-launcher.ts` - Conditional terminal guide dialog display - `src/lib/backend.ai-client-esm.ts` - Added feature flags for version compatibility ### Background With the new copy-on-terminal feature (manager v25.13.2+), users can copy text by simply selecting it with the mouse when tmux mouse setting is enabled. This makes the terminal guide popup unnecessary for newer versions. **Checklist:** - [ ] Documentation - [ ] Minimum required manager version: 25.13.2 for copy-on-terminal feature - [ ] Specific setting for review: Test with both old and new manager versions - [ ] Minimum requirements to check during review: Verify guide shows only on older versions - [x] Test case: Terminal guide should not appear with manager v25.13.2+, should appear with older versions [FR-1426]: https://lablup.atlassian.net/browse/FR-1426?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
graphite-app
bot
force-pushed
the
feat/FR-1426-conditional-terminal-guide
branch
from
b3cd91d to
bbb56b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4220 (FR-1426)
Changes
This PR implements conditional display of the terminal guide dialog based on the new copy-on-terminal feature support.
Key Changes
Added copy-on-terminal feature flag
Conditional terminal guide display
copy-on-terminalfeature is NOT supportedCode organization
reservoirfeature flag to correct version section (25.12.0)Files Changed
src/components/backend-ai-app-launcher.ts- Conditional terminal guide dialog displaysrc/lib/backend.ai-client-esm.ts- Added feature flags for version compatibilityBackground
With the new copy-on-terminal feature (manager v25.13.2+), users can copy text by simply selecting it with the mouse when tmux mouse setting is enabled. This makes the terminal guide popup unnecessary for newer versions.
Checklist: