Skip to content

feat(FR-1426): conditionally show terminal guide based on copy feature support #4414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −3
Open

feat(FR-1426): conditionally show terminal guide based on copy feature support #4414

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/components/backend-ai-app-launcher.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1548,7 +1548,8 @@ export default class BackendAiAppLauncher extends BackendAIPage {
* Open a guide for terminal
*/
_openTerminalGuideDialog() {
this.terminalGuideDialog.show();
!globalThis.backendaiclient.supports('copy-on-terminal') &&
this.terminalGuideDialog.show();
Comment on lines +1551 to +1552
Copy link

Copilot AI Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Using the && short-circuit operator for a conditional action reduces readability. Consider using an explicit if statement: if (!globalThis.backendaiclient.supports('copy-on-terminal')) { this.terminalGuideDialog.show(); }

Suggested change
!globalThis.backendaiclient.supports('copy-on-terminal') &&
this.terminalGuideDialog.show();
if (!globalThis.backendaiclient.supports('copy-on-terminal')) {
this.terminalGuideDialog.show();
}

Copilot uses AI. Check for mistakes.
}

/**
Expand Down
5 changes: 3 additions & 2 deletions src/lib/backend.ai-client-esm.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -813,13 +813,14 @@ class Client {
}
if (this.isManagerVersionCompatibleWith('25.12.0')) {
this._features['mount-by-id'] = true;
this._features['reservoir'] = true;
}
if (this.isManagerVersionCompatibleWith('25.13.0')) {
this._features['pending-session-list'] = true;
this._features['endpoint-lifecycle-ready-stage'] = true;
}
if (this.isManagerVersionCompatibleWith('25.12.0')) {
this._features['reservoir'] = true;
if (this.isManagerVersionCompatibleWith('25.13.2')) {
this._features['copy-on-terminal'] = true;
}
}

Expand Down