Skip to content

Conversation

@nowgnuesLee
Copy link
Contributor

@nowgnuesLee nowgnuesLee commented Oct 24, 2025

resolves #4447 (FR-1602)

This PR changes the language identifier in the ShellScriptEditModal component from "shell" to "sh" for the code editor. This ensures proper syntax highlighting when editing shell scripts in the UI.

Checklist:

  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

Copy link
Contributor Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the size:XS ~10 LoC label Oct 24, 2025
@nowgnuesLee nowgnuesLee marked this pull request as ready for review October 24, 2025 06:17
@Copilot Copilot AI review requested due to automatic review settings October 24, 2025 06:17
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the syntax highlighting in the shell script editor by updating the CodeMirror language identifier from "shell" to "sh" in the ShellScriptEditModal component.

Key Changes:

  • Updated the language prop value in the BAICodeEditor component from "shell" to "sh"

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions
Copy link

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements 4.65% 532/11432
🔴 Branches 3.76% 302/8028
🔴 Functions 2.88% 102/3544
🔴 Lines 4.6% 514/11172

Test suite run success

121 tests passing in 14 suites.

Report generated by 🧪jest coverage report action from e76f61e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS ~10 LoC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

code mirror doesn't support 'shell' anymore.

1 participant