chore: Update MinIO healthcheck settings in compose files #7883
Conversation
Reduced healthcheck interval and timeout, and increased retries for the MinIO service in both docker-compose.halfstack-ha.yml and docker-compose.halfstack-main.yml. This should improve responsiveness and reliability of health monitoring.
Yaminyam
added
skip:changelog
There was a problem hiding this comment.
Pull request overview
This PR updates the MinIO healthcheck configuration in two Docker Compose files to improve health monitoring responsiveness. The changes reduce polling intervals and timeouts while increasing retry attempts to detect service health status more quickly.
Key changes:
- Healthcheck interval reduced from 30s to 5s for faster detection
- Timeout reduced from 20s to 3s for quicker failure identification
- Retries increased from 3 to 10 to reduce false positives
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| docker-compose.halfstack-main.yml | Updates MinIO healthcheck parameters to more aggressive polling settings |
| docker-compose.halfstack-ha.yml | Updates MinIO healthcheck parameters to more aggressive polling settings (identical to main config) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| interval: 5s | ||
| timeout: 3s | ||
| retries: 10 |
There was a problem hiding this comment.
The reduced interval (5s) combined with increased retries (10) will cause health checks to run significantly more frequently, increasing CPU and network overhead. Each check spawns a curl process and makes an HTTP request. This 6x increase in check frequency may impact system resources, especially in resource-constrained environments. Consider whether this aggressive polling is necessary, or if a moderate interval like 10s or 15s would provide adequate responsiveness while reducing resource consumption.
| interval: 5s | |
| timeout: 3s | |
| retries: 10 | |
| interval: 15s | |
| timeout: 3s | |
| retries: 5 |
| interval: 5s | ||
| timeout: 3s | ||
| retries: 10 |
There was a problem hiding this comment.
The timeout value of 3s is set at 60% of the interval (5s), which could lead to overlapping health checks if the MinIO service is slow to respond. Docker's best practice recommends keeping the timeout significantly lower than the interval to prevent health check processes from accumulating. Consider reducing the timeout to 2s or increasing the interval to ensure adequate separation between consecutive health checks.
| timeout: 20s | ||
| retries: 3 | ||
| interval: 5s | ||
| timeout: 3s |
There was a problem hiding this comment.
The timeout value of 3s is set at 60% of the interval (5s), which could lead to overlapping health checks if the MinIO service is slow to respond. Docker's best practice recommends keeping the timeout significantly lower than the interval to prevent health check processes from accumulating. Consider reducing the timeout to 2s or increasing the interval to ensure adequate separation between consecutive health checks.
| timeout: 3s | |
| timeout: 2s |
| interval: 5s | ||
| timeout: 3s | ||
| retries: 10 |
There was a problem hiding this comment.
The reduced interval (5s) combined with increased retries (10) will cause health checks to run significantly more frequently, increasing CPU and network overhead. Each check spawns a curl process and makes an HTTP request. This 6x increase in check frequency may impact system resources, especially in resource-constrained environments. Consider whether this aggressive polling is necessary, or if a moderate interval like 10s or 15s would provide adequate responsiveness while reducing resource consumption.
| interval: 5s | |
| timeout: 3s | |
| retries: 10 | |
| interval: 15s | |
| timeout: 3s | |
| retries: 5 |
Reduced healthcheck interval and timeout, and increased retries for the MinIO service in both docker-compose.halfstack-ha.yml and docker-compose.halfstack-main.yml. This should improve responsiveness and reliability of health monitoring.