feat(zeromq): Allow external zmq.asyncio.Context injection #43
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
zmq.asyncio.Contextthroughtransport_opts["zctx"]CLAUDE.mdfor development environment guideMotivation
Applications using callosum may want to share a single ZMQ context across multiple
Peerinstances throughout the application lifecycle. This reduces resource overhead and follows ZMQ best practices of using one context per application.Changes
ZeroMQBaseTransport.__init__(): Check fortransport_opts["zctx"]and use it if providedZeroMQBaseTransport.close(): Skipcontext.destroy()for externally injected contextsUsage
Test plan
test_external_context_injection: Verifies external context is used and not destroyed on closetest_internal_context_destroyed_on_close: Verifies internal context is destroyed on close