fix some bugs #6210

newfish-cmyk · 2026-01-07T08:34:18Z

修复变量更新节点文件数组类型转换错误

移除了自动将文件 URL 字符串数组转换为对象数组的逻辑，避免下游节点接收到错误的数据格式。

修复表单输入节点 sessionStorage 共享冲突

移除了基于 sessionStorage 的表单缓存机制，改为直接使用 defaultValues，解决多个表单节点相互覆盖导致默认值不显示的问题。

修复代码节点切换语言后 AI 使用旧语言生成代码

将 Copilot 组件改为使用实时传入的节点数据，避免缓存延迟导致 AI 读取到旧的语言配置。

修复自定义反馈节点并发写入冲突和交互节点后写入失败

将自定义反馈从各节点独立异步写入改为统一收集后集中写入，解决并发冲突和时序依赖问题。

gru-agent · 2026-01-07T08:34:29Z

TestGru Assignment

Summary

Link	CommitId	Status	Reason
Detail	`535a0a6`	✅ Finished

History Assignment

Files

File	Pull Request
projects/app/src/pages/api/v2/chat/completions.ts	❌ Failed (The test job failed due to an environment issue: vitest cannot resolve the import path '../../../../projects/app/src/pages/api/v2/chat/completions' from the test file. This is not a source code bug, but rather a problem with the test runner's workspace/project root configuration or file path resolution. The test file itself is correct and covers the logic, but the framework cannot load files outside the workspace root.)

Tip

You can @gru-agent and leave your feedback. TestGru will make adjustments based on your input

github-actions · 2026-01-07T08:37:06Z

Preview sandbox Image:

registry.cn-hangzhou.aliyuncs.com/fastgpt/fastgpt-pr:fatsgpt_sandbox_a1cf82c73bfc8ee12c3c7365efcd5bdf2a5fb153

github-actions · 2026-01-07T08:37:07Z

Preview mcp_server Image:

registry.cn-hangzhou.aliyuncs.com/fastgpt/fastgpt-pr:fatsgpt_mcp_server_a1cf82c73bfc8ee12c3c7365efcd5bdf2a5fb153

github-actions · 2026-01-07T08:38:53Z

Docs Preview:

🚀 FastGPT Document Preview Ready!

🔗 👀 Click here to visit preview

github-actions · 2026-01-07T08:44:27Z

Preview fastgpt Image:

registry.cn-hangzhou.aliyuncs.com/fastgpt/fastgpt-pr:fatsgpt_a1cf82c73bfc8ee12c3c7365efcd5bdf2a5fb153

projects/app/src/pages/api/v2/chat/completions.ts

Copilot

Pull request overview

This pull request addresses multiple bugs related to workflow execution, interactive components, and custom feedback handling. The fixes primarily focus on improving data flow consistency, fixing state management issues, and resolving database write conflicts.

Key Changes:

Refactored custom feedback collection to batch feedbacks at workflow level instead of individual node-level writes
Removed sessionStorage-based form state persistence that caused issues with multiple interactive nodes
Fixed code copilot to use real-time inputs/outputs instead of fetching from node state
Moved variable type conversions and interactive request detection to appropriate locations in the execution flow

Reviewed changes

Copilot reviewed 16 out of 18 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
projects/app/src/pages/api/v2/chat/completions.ts	Moved `isInteractiveRequest` calculation earlier before workflow dispatch
projects/app/src/pageComponents/app/detail/WorkflowComponents/Flow/nodes/NodeCode/index.tsx	Passed real-time inputs/outputs to NodeCopilot component
projects/app/src/pageComponents/app/detail/WorkflowComponents/Flow/nodes/NodeCode/Copilot.tsx	Updated to use passed inputs/outputs instead of fetching from node state
projects/app/src/components/core/chat/components/Interactive/InteractiveComponents.tsx	Removed sessionStorage persistence logic for form data
projects/app/src/components/core/chat/components/AIResponseBox.tsx	Removed chatItemDataId parameter and sessionStorage handling
packages/service/core/workflow/dispatch/utils.ts	Added file variable handling to convert URL strings to file objects
packages/service/core/workflow/dispatch/type.d.ts	Added customFeedbacks field to DispatchFlowResponse
packages/service/core/workflow/dispatch/tools/runUpdateVar.ts	Removed file URL to object conversion and cloneVariables usage
packages/service/core/workflow/dispatch/tools/customFeedback.ts	Simplified to return feedback in response instead of immediate database write
packages/service/core/workflow/dispatch/plugin/run.ts	Added customFeedbacks collection from plugin workflow
packages/service/core/workflow/dispatch/loop/runLoop.ts	Added customFeedbacks collection from loop iterations
packages/service/core/workflow/dispatch/index.ts	Added batch custom feedback write logic and responseChatItemId resolution
packages/service/core/workflow/dispatch/child/runApp.ts	Added customFeedbacks propagation from child app
packages/service/core/chat/controller.ts	Simplified addCustomFeedbacks function and added proper appId type conversion
packages/global/core/workflow/runtime/type.d.ts	Removed cloneVariables from ChatDispatchProps and added customFeedbacks to result
packages/global/core/workflow/runtime/constants.ts	Added customFeedbacks enum value
document/data/doc-last-modified.json	Updated modification timestamps for documentation files
document/content/docs/upgrading/4-14/4145.mdx	Added bug fix descriptions for version 4.14.5

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

packages/service/core/workflow/dispatch/utils.ts

packages/global/core/workflow/runtime/type.d.ts

packages/service/core/workflow/dispatch/index.ts

packages/service/core/workflow/dispatch/utils.ts

Copilot

Pull request overview

Copilot reviewed 19 out of 21 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-09T07:18:02Z

packages/service/core/workflow/dispatch/utils.ts

    else if (item.type === VariableInputEnum.file) {
-      copyVariables[item.key] = cloneVariables[item.key];
+      const currentValue = copyVariables[item.key];
+
+      copyVariables[item.key] = currentValue
+        .map((url: string) => {
+          try {
+            const urlObj = new URL(url);
+            // Extract key: remove bucket prefix (e.g., "/fastgpt-private/")
+            const key = decodeURIComponent(urlObj.pathname.replace(/^\/[^/]+\//, ''));
+            const filename = path.basename(key) || 'file';
+            const extname = path.extname(key).toLowerCase(); // includes the dot, e.g., ".jpg"
+
+            // Check if it's an image type
+            const isImage = extname && imageFileType.includes(extname);
+
+            return {
+              id: path.basename(key, path.extname(key)), // filename without extension
+              key,
+              name: filename,
+              type: isImage ? ChatFileTypeEnum.image : ChatFileTypeEnum.file
+            };
+          } catch {
+            return null;
+          }
+        })
+        .filter((file: any) => file !== null);


The code assumes currentValue is always an array of strings, but there's no validation to check if currentValue exists or is an array. If currentValue is undefined, null, or not an array, this will throw a runtime error when calling .map(). Consider adding a guard check like: if (!Array.isArray(currentValue)) continue; or return an empty array.

* refactor: fastgpt object storage & global proxy (#6155) * feat: migrate to fastgpt storage sdk * chore: rename env variable * chore: move to sdk dir * docs: object storage * CHORE * chore: storage mocks * chore: update docker-compose * fix: global proxy agent * fix: update COS proxy * refactor: use fetch instead of http.request * fix: axios request base url * fix: axios proxy request behavior * fix: bumps axios * fix: patch axios for proxy * fix: replace axios with proxied axios * fix: upload txt file encoding * clean code * fix: use "minio" for minio adapter (#6205) * fix: use minio client to delete files when using minio vendor (#6206) * doc * feat: filter citations and add response button control (#6170) * feat: filter citations and add response button control * i18n * fix * fix test * perf: chat api code * fix: workflow edge overlap and auto-align in folded loop nodes (#6204) * fix: workflow edge overlap and auto-align in folded loop nodes * sort * fix * fix edge * fix icon * perf: s3 file name * perf: admin get app api * perf: catch user error * fix: refactor useOrg hook to use debounced search key (#6180) * chore: comment minio adapter (#6207) * chore: filename with suffix random id * perf: s3 storage code * fix: encode filename when copy object --------- Co-authored-by: archer <[email protected]> * fix: node card link * json * perf: chat index; * index * chat item soft delete (#6216) * chat item soft delete * temp * fix * remove code * perf: delete chat item --------- Co-authored-by: archer <[email protected]> * feat: select wheather filter sensitive info when export apps (#6222) * fix some bugs (#6210) * fix v4.14.5 bugs * type * fix * fix * custom feedback * fix * code * fix * remove invalid function --------- Co-authored-by: archer <[email protected]> * perf: test * fix file default local upload (#6223) * docs: improve object storage introduction (#6224) * doc --------- Co-authored-by: roy <[email protected]> Co-authored-by: heheer <[email protected]> Co-authored-by: Finley Ge <[email protected]>

pull-request-size bot added the size/L label Jan 7, 2026

c121914yu reviewed Jan 7, 2026

View reviewed changes

projects/app/src/pages/api/v2/chat/completions.ts Outdated Show resolved Hide resolved

projects/app/src/pages/api/v2/chat/completions.ts Show resolved Hide resolved

c121914yu force-pushed the v4.14.5-dev branch from bb2c110 to f278b5a Compare January 8, 2026 06:31

newfish-cmyk force-pushed the fix-bugs branch from 535a0a6 to fdabbd3 Compare January 8, 2026 06:41

pull-request-size bot added size/XXL and removed size/L labels Jan 8, 2026

c121914yu force-pushed the fix-bugs branch from fdabbd3 to b95d47f Compare January 8, 2026 07:23

pull-request-size bot added size/L and removed size/XXL labels Jan 8, 2026

newfish-cmyk force-pushed the fix-bugs branch from b95d47f to 03d1a64 Compare January 8, 2026 07:28

c121914yu requested a review from Copilot January 8, 2026 12:13

Copilot started reviewing on behalf of c121914yu January 8, 2026 12:14 View session

Copilot AI reviewed Jan 8, 2026

View reviewed changes

packages/service/core/workflow/dispatch/utils.ts Show resolved Hide resolved

c121914yu reviewed Jan 8, 2026

View reviewed changes

packages/global/core/workflow/runtime/type.d.ts Show resolved Hide resolved

packages/service/core/workflow/dispatch/index.ts Outdated Show resolved Hide resolved

packages/service/core/workflow/dispatch/utils.ts Show resolved Hide resolved

pull-request-size bot added size/XL and removed size/L labels Jan 9, 2026

newfish-cmyk added 6 commits January 9, 2026 14:17

fix v4.14.5 bugs

c53caaf

type

aeef905

fix

3648d38

fix

593d68e

custom feedback

6705455

fix

8ad137e

newfish-cmyk force-pushed the fix-bugs branch from 9bfef34 to 8ad137e Compare January 9, 2026 06:19

code

0aa6d79

c121914yu requested a review from Copilot January 9, 2026 07:13

Copilot started reviewing on behalf of c121914yu January 9, 2026 07:13 View session

Copilot AI reviewed Jan 9, 2026

View reviewed changes

fix

28eb29b

newfish-cmyk force-pushed the fix-bugs branch from c8c2380 to 28eb29b Compare January 9, 2026 07:33

remove invalid function

a1cf82c

c121914yu approved these changes Jan 9, 2026

View reviewed changes

c121914yu merged commit 357b7f1 into labring:v4.14.5-dev Jan 9, 2026
5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix some bugs #6210

fix some bugs #6210

newfish-cmyk commented Jan 7, 2026 •

edited

Loading

Uh oh!

gru-agent bot commented Jan 7, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Jan 7, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Jan 7, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Jan 7, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Jan 7, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jan 9, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fix some bugs #6210

fix some bugs #6210

Conversation

newfish-cmyk commented Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gru-agent bot commented Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

TestGru Assignment

Summary

Files

Uh oh!

github-actions bot commented Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Preview sandbox Image:

Uh oh!

github-actions bot commented Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Preview mcp_server Image:

Uh oh!

github-actions bot commented Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Docs Preview:

Uh oh!

github-actions bot commented Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Preview fastgpt Image:

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

newfish-cmyk commented Jan 7, 2026 •

edited

Loading

gru-agent bot commented Jan 7, 2026 •

edited

Loading

github-actions bot commented Jan 7, 2026 •

edited

Loading

github-actions bot commented Jan 7, 2026 •

edited

Loading

github-actions bot commented Jan 7, 2026 •

edited

Loading

github-actions bot commented Jan 7, 2026 •

edited

Loading