-
Notifications
You must be signed in to change notification settings - Fork 102
Fix Grafana dashboards and update Docker Compose #388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feature/grafana-example
Are you sure you want to change the base?
Fix Grafana dashboards and update Docker Compose #388
Conversation
- Consolidated Grafana dashboards into `EDDI_Dashboard.json` with corrected metric names (adding `eddi_` prefix). - Verified that `eddi_conversation_start_count_total` is a valid metric backed by an explicit Counter in `RestBotEngine.java`, used for "Throughput" stats. - Updated `docker-compose.yml` (formerly `monitoring.yml`) to use `labsai/eddi:latest` and `grafana/grafana:12.3.0`. - Cleaned up obsolete dashboard files. - Consolidated docker compose files to a single `docker-compose.yml` for the full stack.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
- Consolidated Grafana dashboards into `EDDI_Dashboard.json` with corrected metric names (adding `eddi_` prefix). - Verified that `eddi_conversation_start_count_total` is a valid metric backed by an explicit Counter in `RestBotEngine.java`, used for "Throughput" stats. - Updated `docker-compose.yml` (formerly `monitoring.yml`) to use `labsai/eddi:latest` and `grafana/grafana:12.3.0`. - Containerized Prometheus and Grafana configuration files into custom Docker images to fix volume mount issues in CI environments. - Cleaned up obsolete dashboard files. - Consolidated docker compose files to a single `docker-compose.yml` for the full stack.
- Consolidated Grafana dashboards into `EDDI_Dashboard.json` with corrected metric names (adding `eddi_` prefix). - Updated `docker-compose.yml` (formerly `monitoring.yml`) to use `labsai/eddi:latest` and `grafana/grafana:12.3.0`. - Containerized Prometheus and Grafana configuration files into custom Docker images to fix volume mount issues in CI environments. - Updated `.dockerignore` to include necessary Grafana and Docker configuration files in the build context. - Cleaned up obsolete dashboard files. - Consolidated docker compose files to a single `docker-compose.yml` for the full stack.
- Consolidated Grafana dashboards into `EDDI_Dashboard.json` with corrected metric names (adding `eddi_` prefix). - Updated `docker-compose.yml` (formerly `monitoring.yml`) to use `labsai/eddi:latest` and `grafana/grafana:12.3.0`. - Containerized Prometheus and Grafana configuration files into custom Docker images to fix volume mount issues in CI environments. - Updated `.dockerignore` to include necessary Grafana and Docker configuration files in the build context. - Removed explicit `networks` configuration in `docker-compose.yml` to allow all services to run on the default network, ensuring compatibility with `docker-compose.testing.yml` and integration tests. - Cleaned up obsolete dashboard files. - Consolidated docker compose files to a single `docker-compose.yml` for the full stack.
This PR updates the Grafana dashboard to use the correct metric names found in the
RestBotEngine.javacode. It consolidates the previous fragmented dashboards into a single, working dashboard.It also updates
docker-compose.ymlto launch the full stack (EDDI, Mongo, Prometheus, Grafana) using the latest available images, including Grafana 12.3.0 as requested.Verification:
PR created automatically by Jules for task 3247670514232950040 started by @ginccc
This change is