Skip to content

Retry attempts on communication between parent and child #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Retry attempts on communication between parent and child #89

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 34 additions & 7 deletions blacs/tab_base_classes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
# #
#####################################################################
from zprocess import Process, Interruptor, Interrupted
from zprocess.utils import TimeoutError
import time
import sys
import threading
Expand Down Expand Up @@ -809,16 +810,28 @@ def mainloop(self):
# Send the command to the worker
to_worker = workers[worker_process][1]
from_worker = workers[worker_process][2]
to_worker.put(worker_arg_list)
self.state = '%s (%s)'%(worker_function,worker_process)
# Confirm that the worker got the message:
logger.debug('Waiting for worker to acknowledge job request')
success, message, results = from_worker.get()
try:
to_worker.put(worker_arg_list, 30)
self.state = '%s (%s)'%(worker_function,worker_process)
# Confirm that the worker got the message:
logger.debug('Waiting for worker to acknowledge job request')
success, message, results = from_worker.get(30)
except TimeoutError:
logger.info('Connection timed out. Trying again.')
try:
to_worker.put(worker_arg_list, 30)
self.state = '%s (%s)'%(worker_function,worker_process)
# Confirm that the worker got the message:
logger.debug('Waiting for worker to acknowledge job request')
success, message, results = from_worker.get(30)
except TimeoutError:
raise TimeoutError('BLACs Device thread timed out talking to worker.')
if not success:
logger.info('Worker reported failure to start job')
raise Exception(message)
# Wait for and get the results of the work:
logger.debug('Worker reported job started, waiting for completion')

success,message,results = from_worker.get()
if not success:
logger.info('Worker reported exception during job')
Expand Down Expand Up @@ -915,7 +928,14 @@ def mainloop(self):
message = traceback.format_exc()
self.logger.error('Couldn\'t start job:\n %s'%message)
# Report to the parent whether method lookup was successful or not:
self.to_parent.put((success,message,None))
try:
self.to_parent.put((success,message,None), 30)
except TimeoutError:
self.logger.info('Connection timed out. Trying again.')
try:
self.to_parent.put((success,message,None), 30)
except TimeoutError:
raise TimeoutError('Communication timed out in worker.')
if success:
# Try to do the requested work:
self.logger.debug('Starting job %s'%funcname)
Expand All @@ -942,7 +962,14 @@ def mainloop(self):
results = None
# Report to the parent whether work was successful or not,
# and what the results were:
self.to_parent.put((success,message,results))
try:
self.to_parent.put((success,message,results), 30)
except TimeoutError:
self.logger.info('Connection timed out. Trying again.')
try:
self.to_parent.put((success,message,results), 30)
except TimeoutError:
raise TimeoutError('Communication timed out in worker.')


class PluginTab(object):
Expand Down